Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags are not positioned correctly on buildings with garrisoned units #5

Closed
hhirsch opened this issue Jul 7, 2018 · 4 comments
Closed

Comments

@hhirsch
Copy link
Contributor

hhirsch commented Jul 7, 2018

No description provided.

@Jineapple
Copy link
Collaborator

There is a checkbox for "adjust garrison flags". If you use the WK architecture showcase mod on voobly, you should check it, it shifts the flags for the new models. If you use the default architecture, make sure this box is unchecked.

@hhirsch
Copy link
Contributor Author

hhirsch commented Jul 8, 2018

I ran some tests and these are the results.
briton-castle-original
Briton Castle with the WK flag option enabled and the showcase mod disabled
briton-castle
Briton Castle with the WK flag option enabled and the showcase mod enabled
berber-castle
Berber Castle with the WK flag option enabled and the showcase mod enabled

This is the mod I am using https://www.voobly.com/gamemods/mod/858/WK-Architectures-showcase

@Jineapple
Copy link
Collaborator

Jineapple commented Jul 8, 2018

The first two are as expected. For the Berber Castle, I think that one is a new addition to the showcase mod and the Flags adjustment file hasn't been updated.

@TriRem / @AoE2CommunityGitHub is that something you could look into? Needs to be added to the WKFlags.txt file. Format should be: Civ ID, Unit ID,Delta Index of the flag in the garrison graphics, new x coordinate, new y coordinate.

Would need two lines for the two flags. Possibly for other recent additions to the showcase mod as well.

@Jineapple
Copy link
Collaborator

Should be fixed in 5.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants