Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: tab session is not opened as expected #1057

Closed
Drincann opened this issue Sep 12, 2022 · 3 comments
Closed

bug: tab session is not opened as expected #1057

Drincann opened this issue Sep 12, 2022 · 3 comments

Comments

@Drincann
Copy link
Contributor

Drincann commented Sep 12, 2022

Short description

I tried to open the history tab session by clicking as usual, but nothing happens, the window is not opened.(I also used Save Tab Groups for Tab Session Manager)
But there are some tab session that do open, and I don't see any inherent connection between them.

Steps to reproduce

  • Move the window so that the visible area of the window is below 50%.
  • Use the TabSessionManager to save the window as a session.
  • Double click the session, and nothing happens.

Like the following:

image

image

Expected result

The tab session is opened.

Actual result

image

image

image

I can confirm that it is a problem in this line.

How can I see the unuglify code in devtools and maybe I can troubleshoot the problem myself?

Platform information

  • Platform (OS): macOS Big Sur 11.6.7
  • Version of browser: chrome: 105.0.5195.102 (x86_64)
  • Version of Tab Session Manager: 6.12.0
  • Version of Save Tab Groups for Tab Session Manager 1.0.2

Additional context

nothing

@Drincann Drincann changed the title bug: bug: tab session is not opened as expected Sep 12, 2022
@Drincann
Copy link
Contributor Author

Drincann commented Sep 12, 2022

https://source.chromium.org/chromium/chromium/src/+/d51682b36adc22496f45a8111358a8bb30914534

I think the problem here is that the window is not properly positioned and sized, causing the create call to fail.

I have many monitors with my macbook, but sometimes I only use the screen of my macbook, in this case, the session saved when multi-screen is most likely not suitable for display when single macbook screen, and this problem arises.

Maybe we can catch this error and try to open the window again in some safe mode (e.g. width: 800, height: 600, left: 0, top: 0).

@Drincann
Copy link
Contributor Author

fixed here #1058

@sienori
Copy link
Owner

sienori commented Sep 13, 2022

Thank you for your report and PR!

@sienori sienori closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants