Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto saving closed window with option set off #31

Closed
meoso opened this issue Nov 10, 2017 · 6 comments
Closed

auto saving closed window with option set off #31

meoso opened this issue Nov 10, 2017 · 6 comments

Comments

@meoso
Copy link

meoso commented Nov 10, 2017

It is auto-saving upon window close even though i turned it off.

Firefox 56.0.2
Linux 4.9.0-4-amd64 #1 SMP Debian 4.9.51-1 (2017-09-28) x86_64 GNU/Linux

@sienori sienori added the bug label Nov 13, 2017
@sienori
Copy link
Owner

sienori commented Nov 15, 2017

I tried it in the same environment as you, but it did not happen.
Have you pressed the save setting button?
Does it happen if you restart the browser?

@meoso
Copy link
Author

meoso commented Nov 15, 2017

definitely pressed "save". i set max to "1" so that i'm not flooded with them. i've restarted a million times. not a huge problem.

config image
proof image

@mjr66
Copy link

mjr66 commented Nov 24, 2017

Seeing the same behaviour here, I'm afraid.

Can't seem to see a "save settings" button anywhere, but I have the same settings as meoso and they are remembered between Firefox sessions, so maybe there's no need to manually save them by now.

@sienori
Copy link
Owner

sienori commented Nov 24, 2017

I fix it.
The problem occurred when firefox was started with setting off.
9697e3f

@fnagel
Copy link

fnagel commented Nov 28, 2017

Same here. Option does not work at all.

@mjr66
Copy link

mjr66 commented Nov 30, 2017

Seems to be fixed now. Thanks!

@sienori sienori added solved and removed solved? labels Dec 17, 2017
@sienori sienori closed this as completed Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants