[warn] background/export: exportSessions() Error: filename must not contain illegal characters (aka "no startup backup")

[CircleCode]

Short description

until version 6.7.0, startup backup were working as expected
starting from version 6.7.0, startup backup are no more saved.

(perhaps) useful logs

I get the following logs after startup:

[debug] background/backup: backupAllSessions
[debug] background/export: exportSessions() null TSM true
[debug] background/getSessions: getSessions() null null
[debug] background/sessions: getAll() null
[debug] background/sessions: =>getAll() 
Array(31) [ {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, … ]
[warn] background/export: exportSessions() Error: filename must not contain illegal characters

But since download path is not logged, I am not able to check further.

I could eventually try to run a local version of the extension to use the debugger and see if I can find more clues.

Platform information

• Platform (OS): arch linux
• Version of browser: firefox nightly 90.0a1 (2021-05-10) (64-bit)
• Version of Tab Session Manager: 6.8.0

[sienori]

What is the language of Firefox?

[CircleCode]

firefox is in english, but the OS is in french

[CircleCode]

I could eventually try to run a local version of the extension to use the debugger and see if I can find more clues.

I was trying to load TSM as temporary addon, but since this is triggered at startup, I do not know how to reproduce the issue in a temporary addon…

[sienori]

What is the date format in TSM settings?

Also, does the session export work?

I was trying to load TSM as temporary addon, but since this is triggered at startup, I do not know how to reproduce the issue in a temporary addon…

To install it as a persistent add-on:

1. Run npm run build
2. Rename dist/tab_session_manager-for-firefox-6.8.0.zip to dist/tab_session_manager-for-firefox-6.8.0.xpi
3. Drag and drop it into firefox

[CircleCode]

What is the date format in TSM settings?

date format is YYYY.MM.DD HH:mm:ss

Also, does the session export work?

it works both in /tmp and in /home/me/Téléchargements/TabSessionManager - Backup

To install it as a persistent add-on…

Will try this

[CircleCode]

To install it as a persistent add-on…

Is there a way to build the extension not minified?

[sienori]

Is there a way to build the extension not minified?

Run npm run watch-dev and zip contents of dev/firefox/ folder and make it .xpi.

[CircleCode]

Here is the faulty name: TabSessionManager - Backup2\Auto Save - Browser exited\2021-05-10 16-43-18 - Debugging - Runtime - this-firefox #browserExit #debug - [3a32d7bc-b57c-4776-ab8f-8321a8cc4e5f].json

I suspected either # or […], but in fact, the problem comes from the path delimiter (\): TabSessionManager - Backup2/Auto Save - Browser exited/2021-05-10 17-06-03 - Add-ons Manager #browserExit #debug - [239fca16-dfbb-4db1-aea1-21a1e3d891bc].json works

[sienori]

Thanks for the research! I've fixed it. 267b999

[CircleCode]

Thanks for the quick fix!