Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple-Translate broken with NoScript (Incompatbility on Ubuntu 16.04) #84

Closed
WPFilmmaker opened this issue Apr 11, 2018 · 7 comments
Closed
Labels

Comments

@WPFilmmaker
Copy link

As per title, with FF 56 everything was fine, with 59 the button doesn't appear anymore (despite being toggled in the options). I tried to restart FF and simple-translate but without luck. Can someone else confirm this?

@WPFilmmaker
Copy link
Author

Update: Simple-Translate is still dead. I checked the reviews on addons website and one user today reported that it wasn't working. He didn't specfy the OS but I am assuming it was a linux distro.. @sienori do you have a chance to test it on a linux platform?Tank you.

@sienori
Copy link
Owner

sienori commented Apr 13, 2018

It worked normally on Debian9.x FF59.
Please delete the browser cookie.

@WPFilmmaker
Copy link
Author

WPFilmmaker commented Apr 13, 2018

@sienori I deleted cookies and cache, restarted FF and nothing changed.

Then I disabled all my addons and Simple-Translate worked again! I started enabling each one after another checking S-T and the culprit is Noscript!

If it is enabled the pop-up doesn't appear. I thought the issue could be that I was blocking certain script, but then I tried on a page where all the scrips were allowed and it didn't work.

So I can confirm that there is (at the least on my system Lubuntu 16.04.3, latest FF) a problem between Noscript 10.1.7.5 and Simple-Translate 1.73

No the question is what exactly Noscript does that breaks S-T :/

I tried to export Noscript settings unfortunately there is nothing useful there, just the websites and their privileges. If you can tell me how I could provide more info, I will be happy to do so.

@WPFilmmaker WPFilmmaker changed the title After updating FF to 59 simple-translate stopped working (Ubuntu) After updating FF to 59 simple-translate stopped working Ubuntu (NoScript Incompatbility) Apr 16, 2018
@WPFilmmaker WPFilmmaker changed the title After updating FF to 59 simple-translate stopped working Ubuntu (NoScript Incompatbility) Simple-Translate broken with NoScript (Incompatbility on Ubuntu 16.04) May 12, 2018
@WPFilmmaker
Copy link
Author

A little update, I updated FF to 60.0 and the problem persist. Unless I disable Noscropt Simple-Translate won't work. If I enable "Display the context menu" I get the popup with three dots*. Therefore I am assuming the addon is being blocked when it tries to reach google servers by some NoScript function. @sienori Do you think you can look into this?

Noscript 10.1.8.1 and Simple-Translate 1.73, FF 60, Lubuntu 16.04.3

@C37H40O9
Copy link

In General NoScript settings on Default tab set 'fetch' option. After that S-T works for me (Firefox 60, OpenSuse 42.3)

@WPFilmmaker
Copy link
Author

@C37H40O9 Thank you it works!
@sienori seems that 'fetch' is about XmlHttpRequest or Fetch APIs, is it normal that S-T doesn't work without them? Is there something that can be done apart from C37H40O9's workaround? (which however affects Noscript protection?)

@sienori
Copy link
Owner

sienori commented Jun 2, 2018

Thanks for the report!
This add-on uses XmlHttpRequest for translation.
There is no choice but to change Noscript settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants