Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify WG length #15

Closed
lukasc-ubc opened this issue Nov 21, 2015 · 9 comments
Closed

Specify WG length #15

lukasc-ubc opened this issue Nov 21, 2015 · 9 comments
Assignees
Milestone

Comments

@lukasc-ubc
Copy link
Member

Once drawn, give user ability to type in a length, and have waveguide adjust itself.

Add Length as parameter in waveguide PCell. Gettable & Settable.

lukasc-ubc pushed a commit that referenced this issue Mar 24, 2016
@lukasc-ubc lukasc-ubc modified the milestones: 2016_04, 2016/04/10 Apr 8, 2016
@jaspreetj jaspreetj mentioned this issue Apr 10, 2016
@jaspreetj
Copy link
Collaborator

Works but needs improvement. There are some bugs eg. sometimes the layout disappears upon the completion of the resizing operation.

press Ctrl + Shift + R to run the script while having a transient selection.

lukasc-ubc added a commit that referenced this issue Apr 10, 2016
MC for Original GCs; Resize Waveguide Fix #15
@lukasc-ubc
Copy link
Member Author

Hi Jaspreet,

A few problems:

  • Layout disappears. I've seen this before when using a GUI and performing operations. In my case, the solution was to close the GUI first, then perform layout modifications
  • if you select the waveguide, it crashes. only works if you select the path. should work for both. see my script "Waveguide_to_path"

Suggestions:

  • remove 1st and last segments; these presumably never will be useful.
  • perhaps only list eligible segments: name those whose neighbour segments point in the same direction (middle of a U-shape being the only allowable one).

Other:

  • i edited the script: message text change, and added to menu.

@lukasc-ubc lukasc-ubc reopened this Apr 11, 2016
@lukasc-ubc
Copy link
Member Author

fixed:

  • layout disappears
  • selection for PCell vs. GUIDING_PATH; both work
  • correctly measuring the path length including bends
  • added Undo functionality
  • removed 1st/last points.

to do:

  • quality control checking
  • perhaps only list eligible segments: name those whose neighbour segments point in the same direction (middle of a U-shape being the only allowable one).

@lukasc-ubc
Copy link
Member Author

Bug:

  • if the segment to be moved is on the left, it applies the "diff" in the incorrect direction (makes the waveguide shorter instead of longer)

@lukasc-ubc lukasc-ubc added the bug label Apr 11, 2016
@jaspreetj
Copy link
Collaborator

working on the Bug and to do items.

@jaspreetj
Copy link
Collaborator

Fixed: if the segment to be moved is on the left, it applies the "diff" in the incorrect direction (makes the waveguide shorter instead of longer)

New Bug detected: Waveguide resizer does not work on a waveguide which has already been resized. It moves the waveguide to the origin(0,0).

Currently Working on it.

@lukasc-ubc
Copy link
Member Author

Bug: segment says "horizontal" but it is vertical.

@jaspreetj jaspreetj mentioned this issue Apr 11, 2016
lukasc-ubc added a commit that referenced this issue Apr 12, 2016
units; merged the outputs into a read-only text field
@lukasc-ubc
Copy link
Member Author

did some GUI improvements.

@lukasc-ubc lukasc-ubc removed the bug label Apr 12, 2016
@jaspreetj
Copy link
Collaborator

The script was giving me syntax errors. So I did following fixes.

I commented out the line no. 110.

and changed line no. 79 from
if len(o_selection)<>1:
to
if len(o_selection)< 1:

lukasc-ubc pushed a commit that referenced this issue Nov 4, 2023
Update from Master

Former-commit-id: 0971c7e
lukasc-ubc added a commit that referenced this issue Nov 4, 2023
MC for Original GCs; Resize Waveguide Fix #15


Former-commit-id: d6433fb
lukasc-ubc added a commit that referenced this issue Nov 4, 2023
units; merged the outputs into a read-only text field


Former-commit-id: b1edca7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants