Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Peggy] Static Analysis (High) - State variable shadowing in BridgeBank #323

Closed
EddCS opened this issue Nov 30, 2020 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@EddCS
Copy link
Contributor

EddCS commented Nov 30, 2020

Slither raised a high severity warning about state variable shadowing of BridgeBank_initialized and its parent contracts CosmosWhiteList_initialized and EthereumWhiteList._initialized.

INFO:Detectors:
BridgeBank._initialized (BridgeBank/BridgeBank.sol#27) shadows:
        - CosmosWhiteList._initialized (BridgeBank/CosmosWhiteList.sol#11)
        - EthereumWhiteList._initialized (BridgeBank/EthereumWhitelist.sol#9)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#state-variable-shadowing

If this is decided to just be noise we can change slither to ignore this error in the future.

@EddCS EddCS added the bug Something isn't working label Nov 30, 2020
@stbeyer
Copy link

stbeyer commented Nov 30, 2020

This is a side effect of the upgradability pattern. I think it's a false positive

@EddCS
Copy link
Contributor Author

EddCS commented Dec 1, 2020

Okay, I've added this specific warning to the slither triage config file so it won't appear on future runs.

@khdegraaf
Copy link
Contributor

this has been fixed in slither config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants