Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a proper log system #10

Closed
Conr86 opened this issue Oct 9, 2019 · 1 comment · Fixed by #12
Closed

Implement a proper log system #10

Conr86 opened this issue Oct 9, 2019 · 1 comment · Fixed by #12
Assignees
Milestone

Comments

@Conr86
Copy link
Member

Conr86 commented Oct 9, 2019

At the moment, there is no logging system other than printing to the console.

We need a proper log system, I've been looking at loguru which looks excellent. We just need to sort out how to do it between processes. I think either sending the pickled log data or just the final log string over the process pipe should be fine.

@Conr86 Conr86 added this to the v1.0 milestone Oct 9, 2019
@Conr86 Conr86 self-assigned this Oct 9, 2019
@Conr86
Copy link
Member Author

Conr86 commented Oct 23, 2019

The logging branch contains an overhaul of the logging system. We're now using Python's built-in logging system and logging to stdout, not to a file. This is intentional, as supervisord will capture the log from stdout and save it to a file, as well as making it available on the web interface. This means we can have the log displayed on the SARTInterface (under the log modal). supervisord also provides a XML-RPC API to start / stop processes, and get the contents of the log, among other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant