Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to rerun a phase at the end of the furyctl execution #504

Open
nutellinoit opened this issue Apr 23, 2024 · 2 comments · May be fixed by #514
Open

Add a flag to rerun a phase at the end of the furyctl execution #504

nutellinoit opened this issue Apr 23, 2024 · 2 comments · May be fixed by #514

Comments

@nutellinoit
Copy link
Member

A flag like --extra-phase-apply (or a better name) could be useful when creating OnPremises cluster to re-apply the distribution phase after the plugin phase (that often contains the storage plugin)

@ralgozino
Copy link
Member

I gave some thought to this in the past, one option could be to be able to specify more than one phase, like this:

furyctl apply cluster --phase=plugin,distribution

But for the particular problem of the plugins it may be better to have "pre" plugins and "post" plugins, so the storage plugin will be a "pre" plugin, for example. Maybe adding a type field to the plugin spec.

A more generic approach could be setting in the plugin after (or before) which phase it should be installed. So for the storage plugin example, it could have a after: kubernetes field.

@nutellinoit
Copy link
Member Author

I gave some thought to this in the past, one option could be to be able to specify more than one phase, like this:

furyctl apply cluster --phase=plugin,distribution

But for the particular problem of the plugins it may be better to have "pre" plugins and "post" plugins, so the storage plugin will be a "pre" plugin, for example. Maybe adding a type field to the plugin spec.

A more generic approach could be setting in the plugin after (or before) which phase it should be installed. So for the storage plugin example, it could have a after: kubernetes field.

It's a little bit tricky to apply only some plugins before a phase, because for example for helm we are using helmfile, and this way we should change a lot of logic to make this possible (multiple ways to render and execute templates)

@Al-Pragliola Al-Pragliola linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants