Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies between specs and sample rules #63

Closed
SherifEldeeb opened this issue Jan 23, 2018 · 4 comments
Closed

Discrepancies between specs and sample rules #63

SherifEldeeb opened this issue Jan 23, 2018 · 4 comments

Comments

@SherifEldeeb
Copy link
Contributor

Schema in the specs defines "reference" and "falsepositives" to be str; yet sometimes they're str, sometimes they are list in the sample rules.

If I may suggest going with "list" and update the rules accordingly, changing single strs to a list with one item for the sake of consistency (I'd gladly update all the rules and submit a PR), or if it will be decided that they could be either a str or list, then update the specs.

@thomaspatzke
Copy link
Member

Thanks for pointing this out! This should be a list of strings, as alternatives are not allowed in the Schema definition. Already fixed that in the specification. PR with the fixed rules would be nice!

@SherifEldeeb
Copy link
Contributor Author

Thanks for updating "falsepositives" in the schema, but I believe "reference" is still defined as str ... I know it's too late to call it "references", but I guess it should be a list as well nevertheless.

re:PR: will do when I have time (hopefully < a week)

@thomaspatzke
Copy link
Member

Yes - just renamed it to references and made a list from it.

Ok, that's fine, looking forward to your PR :)

@SherifEldeeb
Copy link
Contributor Author

should be addressed by #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants