-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepancies between specs and sample rules #63
Comments
Thanks for pointing this out! This should be a list of strings, as alternatives are not allowed in the Schema definition. Already fixed that in the specification. PR with the fixed rules would be nice! |
Thanks for updating "falsepositives" in the schema, but I believe "reference" is still defined as re:PR: will do when I have time (hopefully < a week) |
Yes - just renamed it to references and made a list from it. Ok, that's fine, looking forward to your PR :) |
should be addressed by #64 |
Schema in the specs defines "reference" and "falsepositives" to be
str
; yet sometimes they'restr
, sometimes they arelist
in the sample rules.If I may suggest going with "list" and update the rules accordingly, changing single
str
s to alist
with one item for the sake of consistency (I'd gladly update all the rules and submit a PR), or if it will be decided that they could be either astr
orlist
, then update the specs.The text was updated successfully, but these errors were encountered: