Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nesting of collections and archives in collections #272

Open
jacobagilbert opened this issue Mar 1, 2023 · 1 comment
Open

Allow nesting of collections and archives in collections #272

jacobagilbert opened this issue Mar 1, 2023 · 1 comment

Comments

@jacobagilbert
Copy link
Member

Currently SigMF Collections define the sigmf recordings contained in the collection by specifying the basename to the SigMF Recording, which necessarily is the same for both sigmf-data and sigmf-meta files in the Recording.

This is limiting in that one cannot specify Archives (of Collections or Recordings) or Collections as members of SigMF Collections, which has a variety of valid use cases (e.g.: #271).

This issue seeks to gain consensus around the idea of redefining SigMF Collections such that they can include [sub]Collections and/or archives.

@jacobagilbert
Copy link
Member Author

jacobagilbert commented Mar 1, 2023

There are a few possible ways I can think to accomplish this, and none of them are especially nice:

  1. Add additional fields to the core:streams object. In addition to name we could add collection and archive. This is somewhat annoying since including more than one of these immediately becomes ambiguous and we have tried to avoid situations where "only one of the following fields can be defined".
  2. Update the definition for name so it can be either a .sigmf-meta file name (overload behavior of base-name but require the full filename + extension), or a .sigmf-collection file name (and the hash would be over the collection metadata, which would in turn cover sub-collection recordings/collections hashes ensuring validity of the recursive integrity check), or a .sigmf archive. Archives are a little more complicated since its not clear what exactly should be hashed (there can be more than one metafile inside); we could simply hash the entire tar archive and deal w/ the associated complications of that. Fallback behavior (no .sigmf* extension) would indicate a Recording base name.
  3. Do 2. above but deprecate name and use a new field for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant