Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enhance telemetry #79

Closed
wants to merge 5 commits into from
Closed

Conversation

innovatechs
Copy link
Contributor

@innovatechs innovatechs commented Dec 1, 2022

Collects additional telemetry so that we can report on:

For new users:

  • Which client is the new user registering to sign in for?
  • How many choose GCKey and how many choose Interac?

For exiting users:

  • How many existing users signed in to a new client.

@wmoussa-gc
Copy link

should we close this? @innovatechs @harrdou

@innovatechs
Copy link
Contributor Author

should we close this? @innovatechs @harrdou

This is a new feature which is not yet integrated into the develop branch. We usually keep those features open until we do the merge.

@wmoussa-gc
Copy link

I recommend we close this PR if we're not actively working on it (i.e. has been prioritized by the team for the sprint). The feature/enhanceTelemetry branch is still there and we can re-open a new PR if needed. would that work?

@innovatechs
Copy link
Contributor Author

I recommend we close this PR if we're not actively working on it (i.e. has been prioritized by the team for the sprint). The feature/enhanceTelemetry branch is still there and we can re-open a new PR if needed. would that work?

That works for me. @harrdou ?

@harrdou
Copy link
Contributor

harrdou commented Feb 23, 2023

I've updated the PR description to better explain what this is about. This enhancement was mostly driven by client request for more information about their user' choices.

With the new UX telemetry recently added to release 1.3.x, we now know track how many users choose to sign in with GCKey vs Interac, but not on a per-client basis and we don't distinguish between new and existing users.

The number of users who have registered with more than one client can be determined now at the sector level by querying the database, but cannot be determined at the individual client level. Recording these events in Azure Monitor was just to make the data more accessible via Application Insights.

@harrdou
Copy link
Contributor

harrdou commented Feb 23, 2023

@wmoussa-gc , I'm in agreement we can close the PR and keep the branch around.

@wmoussa-gc wmoussa-gc linked an issue Feb 23, 2023 that may be closed by this pull request
@wmoussa-gc
Copy link

created an issue to track #142

@wmoussa-gc wmoussa-gc closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance telemetry
3 participants