Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Replace Spoken Language Identification with MediaPipe Solutions #116

Closed
AmitMY opened this issue Nov 7, 2023 · 1 comment
Closed
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed spoken-to-signed

Comments

@AmitMY
Copy link
Contributor

AmitMY commented Nov 7, 2023

Problem

The current spoken language identification - implemented in #10 - has limitations, specifically, it struggles with short texts
google/cld3#76 (comment)

Description

The MediaPipe Language identification does not suffer from the same limitations. It is also smaller in size (315kb compared to 1.1mb).

We can replace the current spoken language identification, or better yet, allow for options in the settings.

Alternatives

Keep the current identification. For spoken language change recommendation, don't show the suggestion until the text is "long enough"
image

@AmitMY AmitMY added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed spoken-to-signed labels Nov 7, 2023
@AmitMY
Copy link
Contributor Author

AmitMY commented Nov 29, 2023

fixed in 69641a4

@AmitMY AmitMY closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed spoken-to-signed
Projects
None yet
Development

No branches or pull requests

1 participant