Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized ?params to prefill correctly, resulting in API issues (eg, QR code SMS template) #11447

Open
dylanh724 opened this issue Jul 7, 2021 · 7 comments

Comments

@dylanh724
Copy link


Bug description

For example, Taiwan gov't COVID tracking program will need me to register via QR code (that submits a pre-filled text containing the identity of the venue):

The result is an empty text compose with a broken "to" field (I'll edit this later with a screenshot). Eg:

{smsNum}?body={body} : {realPhoneNumHere}{messageHere}

The actual message has 0 prefilled.

Steps to reproduce

  1. Scan a QR code that has ?parameters to send a prefilled text message.
  2. Watch the "to" field containing the entire API line.
  3. Even if you filled the body and sent, it's still broken due to the to field being messed up.

Actual result:
Prefill params are all in the "to" area: Need to change default app to anything except Signal to work (it's just you guys that don't follow these standards, it appears).

Expected result:
Message should be prefilled as standardized.

Screenshots

TODO

Device info

Device: Samsung S20+
Android version: 11
Signal version: 5.15.6

Link to debug log

n/a

@dylanh724 dylanh724 changed the title Standardized ?params to prefill areas don't work Standardized ?params to prefill correctly, resulting in API issues (eg, QR code SMS template) Jul 7, 2021
@stale
Copy link

stale bot commented Jan 26, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 26, 2022
@stale stale bot closed this as completed Feb 2, 2022
@dylanh724
Copy link
Author

Still relevant.

@cody-signal
Copy link
Contributor

Would you be able to provide a sample QR code and example of expected/actual data.

@cody-signal cody-signal reopened this Feb 2, 2022
@stale stale bot removed the wontfix label Feb 2, 2022
@dylanh724
Copy link
Author

dylanh724 commented Feb 11, 2022

{number}?body=probably%20is%20encoded

In Android, this would prefill the body (similar, if not identical to, mailto email link params). iOS enjoys rebelling against standards, so body param key may differ.

@dylanh724
Copy link
Author

dylanh724 commented Feb 11, 2022

image

Randomly found this on Google. This seems to be a demo, so ignore the actual phone number (not mine).

@stale
Copy link

stale bot commented Apr 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@FlorianObermayer
Copy link

FlorianObermayer commented Apr 27, 2022

Another example for broken parsing:

image

Here, the recipient will be parsed incorrectly, resulting in: ?body=www.whisp.ly/r/cjN0iYN instead of no recipient with body content: www.whisp.ly/r/cjN0iYN#uls1xlZbL2FTQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants