Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large backup to FAT does not warn user of unsuccessful backup #11951

Open
4 tasks done
janvlug opened this issue Feb 2, 2022 · 10 comments
Open
4 tasks done

Large backup to FAT does not warn user of unsuccessful backup #11951

janvlug opened this issue Feb 2, 2022 · 10 comments

Comments

@janvlug
Copy link

janvlug commented Feb 2, 2022


Bug description

When you create a backup of a large > 4.3 GB Signal database to an as "portable" formatted (I guess FAT32) SD-card, a partial backup file is created of 4.3 GB instead of a full backup. The user does not get a warning, and thinks that they have a good backup, which is not the case.

The restore of the partial backup did not get messages back, changed my safety number and disconnected my linked devices.

I consider this as a very severe issue, because I lost all history while I thought that I made a valid backup.

Device info

Device: Nokia 4.2
Android version: 11
Signal version: 0.0.0

Link to debug log

@Meteor0id
Copy link
Contributor

Also (reported before) unsucesful backup files do not get cleaned up, and thus fill up the storage even further. Even disabeling backups does not clear partial backupfiles like it would with completed backup files.

@Roghetti
Copy link

I already opened a pull request to address this: #11900
It is about backup-chunking and splits the backup into 1GB parts to prevent to run into the FAT32-file-size-limit issue.

@stale
Copy link

stale bot commented Apr 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 22, 2022
@stale
Copy link

stale bot commented May 2, 2022

This issue has been closed due to inactivity.

@stale stale bot closed this as completed May 2, 2022
@janvlug
Copy link
Author

janvlug commented May 2, 2022

I'm pretty sure that this issue has not been resolved. Re-opening would be appreciated.

@cody-signal cody-signal reopened this May 2, 2022
@stale stale bot removed the wontfix label May 2, 2022
@stale
Copy link

stale bot commented Jul 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 1, 2022
@janvlug
Copy link
Author

janvlug commented Jul 3, 2022

This issue is still there.

@stale stale bot removed the wontfix label Jul 3, 2022
@stale
Copy link

stale bot commented Sep 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 1, 2022
@michikommader
Copy link

Still open and still a severe issue.

@stale stale bot removed the wontfix label Sep 2, 2022
@janvlug
Copy link
Author

janvlug commented Jan 26, 2024

I'm running again into this issue. I created a forum topic to discuss it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants