Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-character emojis in names render the wrong character on profile pictures #12212

Closed
4 tasks done
WhyNotHugo opened this issue Apr 29, 2022 · 2 comments
Closed
4 tasks done

Comments

@WhyNotHugo
Copy link


Bug description

I have a contact name Bob 🇨🇿 (I know a few people with the same name, so an emoji in the contact's name is super handy. Name if fictitious in this example).

Note that this flag (and all flags, actually) is actually a two-part unicode glyph, which is 🇨 and 🇳 one after the other.

Steps to reproduce

  • Name a contact with a second name starting with a flag emoji, or another emoji which is multiple characters.
  • Click new message.

Make sure you pick a contact with no actual profile picture.

Actual result: Signal renders profile pictures for contacts based on the first letter of their first and last name, which in this case, should be considered B🇨🇿.

Expected result: It seems signal doesn't parse unicode correctly somehow, but the contact's profile pic actually contains B🇨, which is incorrect (and confusing).

Device info

Device: OnePlus 9
Android version: LineageOS 18
Signal version: 5.35.3

@WhyNotHugo
Copy link
Author

Oh, the right name/term for these is grapheme clusters:

A grapheme cluster is a sequence of one or more Unicode code points that should be treated as a single unit by various processes: Text-editing software should generally allow placement of the cursor only at grapheme cluster boundaries.

@WhyNotHugo
Copy link
Author

WhyNotHugo commented May 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants