Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications on smartwatch don't contain message content #12961

Closed
4 tasks done
1nikolas opened this issue May 22, 2023 · 17 comments
Closed
4 tasks done

Notifications on smartwatch don't contain message content #12961

1nikolas opened this issue May 22, 2023 · 17 comments
Labels

Comments

@1nikolas
Copy link


Bug description

When syncing Signal's notifications to my smartwatch, I just get "Most recent from: <contact name>" instead of the message content. I have tried 2 different brand smartwatches and have the same problem so I figured this should be a problem in your end. Notifications on the phone appear fine, it's just what the smartwatch app reads from the system. I found a closed issue about this but it's too old (from the TextSecure days of the app #4038). Maybe it's time to fix this?

Steps to reproduce

  • Have Signal
  • Have a smartwatch with Signal notifications synced
  • Wait for a notification

Actual result: Notification content on the smartwatch is "Most recent from: <contact name>"
Expected result: Notification content should be the message itself

Device info

Device: OnePlus 8T
Android version: 13
Signal version: 6.21.2

@nicholas-signal
Copy link
Contributor

signal-2023-05-22-163312

I am unable to reproduce this issue on my Galaxy Watch5. Would you mind sharing what smartwatch you're using, and what operating system it is running?

@1nikolas
Copy link
Author

1nikolas commented May 22, 2023

It's an OnePlus Watch. The other is a generic Chinese one. I think this is a problem with non-WearOS devices

@nicholas-signal
Copy link
Contributor

I see. Unfortunately, we only have Wear OS and Tizen devices to test with, but Signal uses standard Notification APIs across the board. Do you experience this behavior with other apps like WhatsApp and Telegram?

@1nikolas
Copy link
Author

No. To me it looks like Signal is sending that extra notification (or maybe android does?) and appears on top of the normal message notification. If that notification is not even displayed, what's its purpose?

@1nikolas
Copy link
Author

The notification looks like this (I used a notification log app to see it)
Screenshot_2023-05-22-23-42-23-22_73e67ff144ea0c27af74c0b29b3d293a.jpg

@nicholas-signal
Copy link
Contributor

nicholas-signal commented May 22, 2023

Signal notifications work using a multi-step process:

  1. The Signal service sends an encrypted push message over Google's push notification service. This message contains the bare minimum amount of data to make it to the phone.
  2. Receiving this notification causes the Signal app to "wake up" on the phone, at which point it establishes a direct connection with the Signal service.
  3. Once connected to the Signal service, it retrieves any encrypted data that the service has ready for it.
  4. Locally on the device, the Signal client decrypts the data. Some of it is notification-worthy (a new message) some of it is not (read receipts). For the notification worthy stuff, the app generates a local system notification and hands it off to the operating system.

@1nikolas
Copy link
Author

So this "most recent from" thing has a purpose? And what would be the solution to this? Tell smartwatch manufactures to manually block this notification on their app?

@nicholas-signal
Copy link
Contributor

Can we just check one thing? What do you have this setting set to in your Signal app settings?
Screenshot_20230522_171158

@1nikolas
Copy link
Author

Screenshot_2023-05-23-00-13-16-94_4b14b257287ac0a6d1fd5fbb2487716f.jpg

@nicholas-signal
Copy link
Contributor

Would you mind submitting a debug log?

@1nikolas
Copy link
Author

Don't think there is something with my device specifically but sure
signal-log-1684873784417.zip

@nicholas-signal
Copy link
Contributor

So upon digging into how this all works, I've determined that the Signal app shows a "summary notification" if there's more than one unread conversation. It then replaces this with individual conversation notifications. I'll confer with the team to better understand how this came to be, and how difficult it would be to rearchitect.

@stale
Copy link

stale bot commented Jul 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 22, 2023
@1nikolas
Copy link
Author

Well that's unfortunate.. This is still a problem

@stale stale bot removed the wontfix label Jul 22, 2023
@stale
Copy link

stale bot commented Sep 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 20, 2023
@stale
Copy link

stale bot commented Sep 28, 2023

This issue has been closed due to inactivity.

@stale stale bot closed this as completed Sep 28, 2023
@acolombier
Copy link

Hi, I am also a OnePlus Watch owner and been experiencing this too. As per asked above, other chatting apps like WhatsApp and Messenger displays just fine. I am however unsure if the non-Wear OS would be having some custom logic on it, e.g filtering out the summary notification. I have no experience in Kotlin but I'd be happy to try and help fixing this issue if you would have some suggestion on how to approach it. Do you reckon making the summary notification would bu sufficient or is there a deeper work required for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants