Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable calls for < KK #7841

Closed
4 tasks done
righy opened this issue May 25, 2018 · 3 comments
Closed
4 tasks done

Disable calls for < KK #7841

righy opened this issue May 25, 2018 · 3 comments

Comments

@righy
Copy link

righy commented May 25, 2018


Bug description

When I receive an audio call, Signal restarts right after picking it up. It looks like I can hear the other end for about half a second before it stops. I am then brought to the Signal "enter passphrase" prompt screen.

Steps to reproduce

  • Open Signal
  • Enter the passphrase to unlock Signal
  • Wait until I receive an audio call
  • Pick up the call

Actual result: Signal restarts and I am unable to talk with the correspondent.
Expected result: I can talk with the correspondent.

Device info

Device: HTC Desire (codename bravo)
Android version: 4.0.4 (eng.k900.20120624.010557, IMM76I)
Signal version: 4.19.3

Link to debug log

Output of adb logcat (anonymized) just after Signal restarted:
https://gist.github.com/righy/97566347ad1e4c75ed78e9d70b942c8c

@moxie0 moxie0 changed the title Signal restarts when picking up audio call Disable calls for < KK Jun 15, 2018
@moxie0
Copy link
Contributor

moxie0 commented Jun 15, 2018

Looks like webrtc's minsdk is greater than your version of Android. We should disable calling for < KitKat to prevent it from crashing.

@haffenloher
Copy link
Contributor

haffenloher commented Jun 15, 2018

Calls still work fine on Android 4.2 with Signal 4.20.
Is the missing AcousticEchoCanceler class causing the crash? It got added with 4.1 / Jelly Bean: https://developer.android.com/reference/android/media/audiofx/AcousticEchoCanceler

@alan-signal
Copy link
Contributor

We're now >= KK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants