Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image thumbnail aspect ratios are too landscapey, particularly for portrait-type images #2701

Closed
1 task done
pureandclear opened this issue Aug 29, 2018 · 4 comments
Closed
1 task done
Labels

Comments

@pureandclear
Copy link

  • I have searched open and closed issues for duplicates

Bug description

Image thumbnails are cropped to have a rather extreme landscape (short and wide) aspect ratio, which looks particularly bad if the original image was portrait (tall and narrow).

Steps to reproduce

Send a photo on Signal. Something with a portrait aspect ratio (tall and narrow) will demonstrate it best.

Actual result:

On mobile, the image thumbnail more closely (not perfectly) preserves the aspect ratio of the original image. But on desktop, the image thumbnail is cropped rather extremely to be landscape (wide and short), highly disregarding the aspect ratio of the original image.

Expected result:

Both mobile and desktop should show similar thumbnails, at least somewhat preserving the aspect ratio of the original image.

Screenshots

Here is the test image I used, a portrait of Thomas Jefferson (from Wikipedia).

test

Thumbnail on mobile:

mobile

Thumbnail on PC:

pc

You can see that while the mobile thumbnail does not use the exact aspect ratio of the original, it is at least somewhat close. The desktop thumbnail, however, looks really different from the original.

Platform info

Signal version:

1.15.5

Operating System:

Windows 10 64-bit

Linked device version:

Android 4.25.6

@pureandclear
Copy link
Author

I should add: I'm using a 16:9 monitor. This only happens when it's maximized. If I shrink the window to be narrower, the thumbnail is more true to the original image.

@dront78
Copy link

dront78 commented Sep 12, 2018

It is always happen on window resize, so the image shapes are changed every time.
I can view received portraits only if I resize the main window to have more or less same proportions.
ArchLinux and Signal Desktop v1.16.0

@Xashyar
Copy link
Contributor

Xashyar commented Nov 28, 2018

image

issue seem to be mitigated in 1.19.0

@dront78
Copy link

dront78 commented Feb 8, 2019

confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants