Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security [Signal for macOS]: Lack of quarantine meta-attribute for downloaded files leads to GateKeeper bypass #3590

Closed
Metnew opened this issue Sep 12, 2019 · 9 comments

Comments

@Metnew
Copy link

Metnew commented Sep 12, 2019

Bug Description

Report to Brave: https://hackerone.com/reports/374106

  1. Signal doesn't handle quarantine properly.
  2. Downloaded files bypass Quarantine & Gatekeeper checks
  3. Downloaded files are executable in 2 clicks
  4. .terminal file can be used for this purpose (it's executable after downloading from the web).

OS

macOS

@Metnew
Copy link
Author

Metnew commented Sep 17, 2019

🤔

1 similar comment
@Metnew
Copy link
Author

Metnew commented Nov 21, 2019

🤔

@Metnew Metnew changed the title Security: Lack of quarantine meta-attribute for downloaded files leads to GateKeeper bypass Security [Signal for macOS]: Lack of quarantine meta-attribute for downloaded files leads to GateKeeper bypass Nov 22, 2019
@kenpowers-signal
Copy link
Contributor

Sorry, not quite sure I follow. Are you saying that the same issue that applies to Brave applies to downloaded attachments in Signal?

@Metnew
Copy link
Author

Metnew commented Nov 28, 2019

Exactly this, see for reference:

I also shared my slides about macOS File Quarantine with you (GDrive, email invitation). Please, don't share these slides with others.

Fix: add LSFileQuarantineEnabled=false in Info.plist and make sure auto-updater doesn't quarantine the new version of the app.

@Metnew
Copy link
Author

Metnew commented Nov 28, 2019

@kenpowers-signal Let me know whether you're going to fix this (and when, if you're), so that I can publish my research and send it to IBB. Thanks

@Metnew
Copy link
Author

Metnew commented Dec 9, 2019

@kenpowers-signal ^^

@Metnew
Copy link
Author

Metnew commented Dec 12, 2019

@kenpowers-signal ??

@kenpowers-signal
Copy link
Contributor

Thanks, we're considering this and will update this thread if we decide to change behavior for downloaded files.

@scottnonnenberg-signal
Copy link
Contributor

v1.30.0 introduced quarantine attributes for saved attachments on macOS: 1bf9ca7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants