Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line shortcut should be option-return on Mac #4352

Open
thomasst opened this issue Jun 15, 2020 · 3 comments · Fixed by #4506
Open

New line shortcut should be option-return on Mac #4352

thomasst opened this issue Jun 15, 2020 · 3 comments · Fixed by #4506
Labels

Comments

@thomasst
Copy link

Current behavior:

When typing in single-line mode in Signal (v1.34.2) on macOS, Shift+Return inserts a new line and Option+Return sends the message. This is inconsistent with other macOS apps (e.g. Apple Messages) which use Option-Return to insert a new line.

Expected behavior:

  • Option+Return should insert a new line
  • Shift+Return should behave like Return and should send the message. (Alternatively, for compatibility, it could insert a new line).
@scottnonnenberg-signal
Copy link
Contributor

Thanks @thomasst for letting us know that this has regressed: #4506 (comment)

@Mxchaeltrxn
Copy link

@scottnonnenberg-signal I'd be happy to do this one.

I'll see if I can get this working:

  • Option+Return should insert a new line
  • Shift+Return should behave like Return and should send the message.

I haven't contributed to Signal before so I might need some help if that's okay.

@kjs3
Copy link

kjs3 commented Sep 14, 2023

@Mxchaeltrxn Did you ever attempt to make this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

4 participants