Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent linkifier behavior regarding links ending with ? compared to Android and iOS #6045

Open
2 tasks done
awaitlink opened this issue Jul 25, 2022 · 0 comments
Open
2 tasks done
Labels

Comments

@awaitlink
Copy link
Contributor

awaitlink commented Jul 25, 2022

  • I have searched open and closed issues for duplicates
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Bug Description

When a link ends with ? in a message like ... https://signal.org/?, iOS (and it seems Android as well) include the ? when linkifying and creating a link preview. However, Desktop does not, so it drops the link preview when receiving such messages.

Sending the same message from Desktop instead seems to work however, i.e. at least iOS does not drop the link preview, even though it still linkifies with the ? unlike Desktop (not sure if dropping is implemented on iOS though in the first place; perhaps signalapp/Signal-iOS#5384 is somewhat related in this regard).

#4550 may be related.

Steps to Reproduce

  1. From iOS, send a message containing https://signal.org/?.

Actual Result: Desktop will not show the preview, as its linkifier does not include the ? in the link.
Expected Result: Desktop should have the same linkification behavior and keep the link preview.

Screenshots

(Pay attention to where the underline ends:)

Sending from Android Sending from iOS Receiving from iOS on linked Desktop

Platform Info

Signal Version: 5.52.0-beta.1
Operating System: macOS 13.0 Public Beta (22A5295i)
Linked Device Version: Signal iOS 5.47.0.7

Link to Debug Log

Example message sent timestamp: 1658739801652.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants