Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save dialog opens behind Signal #6046

Open
2 tasks done
CaviaPorcellus opened this issue Jul 25, 2022 · 10 comments
Open
2 tasks done

Save dialog opens behind Signal #6046

CaviaPorcellus opened this issue Jul 25, 2022 · 10 comments

Comments

@CaviaPorcellus
Copy link

CaviaPorcellus commented Jul 25, 2022

  • I have searched open and closed issues for duplicates
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Bug Description

Attempting to save a file of any sort from Signal Desktop brings up the save dialog behind the Signal window.

Steps to Reproduce

  1. Click to download a file (e.g., a picture from a conversation).

Actual Result:

Observe the file save dialog open unfocused behind the Signal window.

Expected Result:

The file save dialog should open focused above the Signal window (as it used to).

Screenshots

Screenshot_20220730_165844

Platform Info

Signal Version: 5.51.0

Operating System: Kubuntu 22.04

Linked Device Version: Android 5.43.7

### Link to Debug Log

@josh-signal
Copy link
Contributor

@CaviaPorcellus can you tell us a bit more about your system?

@CaviaPorcellus
Copy link
Author

@josh-signal What other information would you like?

I've found this same issue on three different computers: a ThinkPad X1 Carbon 7th Gen, a ThinkPad T420s, and a desktop with an Intel i7-8700k CPU (they each use integrated Intel graphics).

All three are using an up-to-date version of Signal linked to Signal Android (also up to date, though linked to different phones/accounts). All are using Kubuntu 22.04 (KDE Plasma 5.24.4; KDE Frameworks 5.92.0; Qt 5.15) with X11.

@josh-signal
Copy link
Contributor

does this happen on any other electron based apps?

@CaviaPorcellus
Copy link
Author

CaviaPorcellus commented Jul 28, 2022

I don't think I use any other Electron-based apps, though I might not know about it. I downloaded and tried the Brave browser (I think that's one?) and the save dialog appeared like normal (i.e., on top of the window, as it should).

@chaot4
Copy link

chaot4 commented Aug 8, 2022

I have the same issue in KDE (under Linux Manjaro). Also, KDE is known to sometimes behave in a non-standard way when it comes to putting windows into foreground/background (see, e.g., here). Unfortunately, I have no suggestion for a fix as I don't know too much about the details of these issues.

@CaviaPorcellus
Copy link
Author

This is not just a problem with KDE (and no other apps I use there have any issues, and Signal used to be fine).

I booted up an Ubuntu 22.04.1 live USB image, installed Signal (now using 5.54.0), and the same issue is present: the save as dialog appears behind the main Signal window.

Screenshot from 2022-08-13 19-35-12

A workaround in KDE is to create a special window rule to make it appear on top (window class: signal-desktop signal-desktop; window role: GtkFileChooserDialog; Keep above other windows). (The class being "signal-desktop signal-desktop" [sic] seems odd to me.) But that doesn't help if you are using Ubuntu and the default Gnome desktop.

The dialog box also does not open focused, so even if forced to the front using the workaround, you still need to click on it to interact with it (change file name, etc.). Maybe part of the issue?

@josh-signal
Copy link
Contributor

Perhaps something changed recently upstream that is causing this. Here's a list of electron based apps, popular ones include visual studio code, slack, discord: https://www.electronjs.org/apps

@CaviaPorcellus
Copy link
Author

Most apps I tried (Discord, Atom, Slack) were fine, but Wire did the same thing as Signal. Maybe this issue?

@tristan957
Copy link

upstream PR for discussion of solutions: electron/electron#35110.

@Zesko
Copy link

Zesko commented Dec 2, 2022

I confirmed this issue.

Signal version 6.0.0

  1. Click a "Download" button on Signal Desktop that opens the GTK dialog in front of Signal's window. That is OK.
  2. Click the "Download" button again, but the GTK dialog is opened behind Singal's window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants