Migrate AppConfig to SDK v2 to detect and use web identify token #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found an validation error about signing the Contributor License Agreement. Had completed singing. |
jon-signal
approved these changes
Jul 16, 2021
|
Ah--it looks like we just needed some kind of event on the pull request to get it to notice that the CLA had been signed. Cheers, and thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When setting up server in RBAC-enabled EKS cluster, the original AppConfig client cannot use web identity token for authentication. This commit make that possible, please consider merge the code.
Thanks,