Fix Authorization header format validation to match RFC HTTP header specifications #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 2616, HTTP header values may have leading and trailing whitespace.
This fix may or may not address the 401 Unauthorized response in signalapp/Signal-iOS#5114 . (I do not own a Mac to be able to run iOS app version 3.9.0 in Xcode Simulator in debug mode, in order to reproduce the issue.) Either way, HTTP clients may implement the Authorization header values according to the RFC spec with leading or trailing whitespace.
Please comment on signalapp/Signal-iOS#5114 if/when this fix is deployed in production. An important Signal contact of mine cannot access years of Signal messages on their old iPhone that can only run iOS 10, which is only supported up to app version 3.9.0. These messages contain important data such as passwords to accounts, photos, and messages to reconstruct a sequence of events that occurred in the past.