Unit test fixes #17
Closed
Unit test fixes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry I didn't see this before, looks like it needs a rebase |
The former assertThat(value == 4) was not actually performing an assertion since there was no .isEqualTo or .isTrue()
|
Looks like the first commit is no longer relevant since WebsocketControllerTest is gone. The other two commits still apply. |
|
sorry, it also looks like you haven't signed the CLA |
|
Ping @mdietz198 -- after signing the CLA, perhaps a squash of the commits as well. |
Closed
|
Honestly I think this should be closed in favour of #81 |
visitpay
pushed a commit
to visitpay/Signal-Server
that referenced
this pull request
Feb 25, 2019
Update readme with buildsys info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran pitest and found two things:
Using the pitest results, I added some more assertions and tests - mostly for error cases - in a branch. If that help is appreciated, I can keep adding some more coverage and make another pull request. If not, no worries. If you're more interested in contributions to the client, I'd be happy to give that a shot.