Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the S3 endpoint, region, and other parameters #77

Closed
wants to merge 3 commits into from
Closed

Allow configuring the S3 endpoint, region, and other parameters #77

wants to merge 3 commits into from

Conversation

paride
Copy link

@paride paride commented Feb 2, 2017

In the Amazon S3 yml configuration read and use the following parameters, here shown with sample values:

s3:
  endpoint: https://my-host.net/
  region: us-east-1
  pathStyleAccess: true
  signerAlgorithm: AWSS3V4SignerType

Being able to specify them allows to self-host an S3 service. The aws-sdk has been updated too, removing the calls to some deprecated methods.

Paride Legovini added 3 commits February 2, 2017 19:37
In the Amazon S3 yml configuration read and use the following
parameters, here shown with sample values:

s3:
  endpoint: https://my-host.net/
  region: us-east-1
  pathStyleAccess: true
  signerAlgorithm: AWSS3V4SignerType

Being able to specify them allows to self-host an S3 service.
The aws-sdk has been updated too, removing the calls to some
deprecated methods.

// FREEBIE
@gine
Copy link

gine commented Feb 23, 2017

it can be useful

@ZennouRachid
Copy link

ZennouRachid commented Mar 13, 2017

@paride Hi, i want to use minio for self-host an S3 service
my yml file configuration look like this:
s3:
accessKey: 1PAVK1425juiUAH
accessSecret: inhoKJSHDUIIrichskiY7Fpc9
attachmentsBucket: bucket
endpoint: http://127.0.0.1:9000
region: us-east-1
pathStyleAccess: true
signerAlgorithm: AWSS3V4SignerType
but it doesn't work, when i try to send an attachment the signal application give my this error "signal has stoped" .
do youi have an idea?

@vadmeste
Copy link

Hey @paride,

Could you update us on the current status of this PR ?

A fast test of this PR shows that Signal-Server doesn't contact the Minio server at all. Even when I replace Minio with nc -l -p 9000, this latter doesn't receive any data.

Regards,

@paride
Copy link
Author

paride commented Mar 14, 2017

@vadmeste It's working fine for me. Normally it is the client that contacts the S3/Minio server, Signal-Server just builds a "Signed Url" that the client then uses to upload the attachment. Of course if you use endpoint: http://127.0.0.1 the client won't be able to contact it.

Edit: https://docs.aws.amazon.com/AmazonS3/latest/dev/PresignedUrlUploadObject.html

@signalapp signalapp locked and limited conversation to collaborators Mar 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
5 participants