Developer improvement #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// FREEBIE
// FREEBIE
// FREEBIE
|
I also attempted to get some of the changes in #17 in there. Hopefully we can close that old pr now |
moxie0
suggested changes
Jun 24, 2017
| @@ -0,0 +1,3 @@ | |||
| language: java | |||
| jdk: | |||
| - oraclejdk8 | |||
| -u 1000 \ | ||
| -e MAVEN_CONFIG=/var/maven/.m2 \ | ||
| maven:alpine \ | ||
| mvn -Duser.home=/var/maven clean test |
There was a problem hiding this comment.
I'd prefer not to mix docker (or shell scripts!) into this
|
No problem.
…On Sun, Jun 25, 2017 at 00:02 Moxie Marlinspike ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In .travis.yml
<#79 (comment)>
:
> @@ -0,0 +1,3 @@
+language: java
+jdk:
+ - oraclejdk8
Please no travis, thanks
------------------------------
In bin/test
<#79 (comment)>
:
> @@ -0,0 +1,9 @@
+#!/bin/sh
+set -exu
+docker run -it --rm \
+ -v ~/.m2:/var/maven/.m2 \
+ -v "$PWD":/usr/src/mymaven -w /usr/src/mymaven \
+ -u 1000 \
+ -e MAVEN_CONFIG=/var/maven/.m2 \
+ maven:alpine \
+ mvn -Duser.home=/var/maven clean test
I'd prefer not to mix docker (or shell scripts!) into this
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#79 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxN224Ff42nqaPuCkswI9NeyvfPVRvyks5sHYdzgaJpZM4OEXJ1>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to get involved in Signal Server and I thought I could clean up the developer experience get started. Hopefully the // FREEBIE tag is how you signify that the money should be kept in the foundation. Happy if all, some or none of this is welcome.