Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sharing an image subject to Signal, transparency is not preserved #5666

Open
3 tasks done
dcormier opened this issue Sep 24, 2023 · 2 comments
Open
3 tasks done

Comments

@dcormier
Copy link

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

On iOS 16 and 17, when selecting the subject of a photo with Apple's Photos app (Apple's docs) and sharing it to Signal, it has a white background instead of transparent.

Steps to reproduce

Actual result:
The image has a while background in the preview and when received.

Expected result:
The image should have a transparent background in the preview and when received. This would match behaviors of other iOS apps. Gmail, Slack, and Facebook Messenger are some 3rd party iOS apps that handle the transparency correctly. The transparency is well supported in first-party iOS apps, like Messenger and Notes.

Screenshots

  • Selecting the subject of an image:
    image

  • Tap "Share...", Signal, then your target, and you'll see this:
    image

  • Go ahead and send it, and this is what's seen:
    image

  • Tap on the received image to see the larger version, to see if the transparency has only been turned white in the thumbnail, and you'll see this:
    image

Device info

Device: iPhone 11 Pro and iPhone 15 Pro

iOS version: iOS 16.7, 17.0.2, but I've seen this since the initial release of iOS 16 when this feature was added.

Signal version: 6.43.0.8

Link to debug log

https://debuglogs.org/ios/6.43.0/8a8bff239cabad9dfd934b01b4c0a10f3f908b02f66584b379ae6e31cec6873a.zip

Additional thought

I just wanted to share one additional thought. I've seen this sort of problem when an image is resized and effort isn't taken to preserve the transparency during the resize. It's something I've done in my own code, and seen in others. Just a suggestion for whoever investigates this. Of course, that's assuming the image isn't transcoded to a format that doesn't support transparency.

@Miguel-Signal
Copy link

Hi @dcormier,

I've gone ahead and filed this bug with our engineering team. While our engineers will be working on a fix, I unfortunately can't give out a specific timeline for a resolution. You may see a fix for this bug included in the release notes for future versions of Signal.

Thanks again for your help in reporting this!

@scallister
Copy link

This also applies to images with transparency for group chat icons, Signal does new preserve image transparency there either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants