Request READ_PHONE_NUMBERS permission when necessary.

signalapp · Nov 19, 2020 · 011efb0 · 011efb0
1 parent 63d00f8
commit 011efb0
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -35,6 +35,7 @@
     <uses-permission android:name="android.permission.SEND_SMS"/>
     <uses-permission android:name="android.permission.WRITE_SMS"/>
     <uses-permission android:name="android.permission.READ_PHONE_STATE" />
+    <uses-permission android:name="android.permission.READ_PHONE_NUMBERS" />
 
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"
                      android:maxSdkVersion="28" />

diff --git a/app/src/main/java/org/thoughtcrime/securesms/registration/fragments/WelcomeFragment.java b/app/src/main/java/org/thoughtcrime/securesms/registration/fragments/WelcomeFragment.java
@@ -3,6 +3,7 @@
 import android.Manifest;
 import android.annotation.SuppressLint;
 import android.content.Context;
+import android.os.Build;
 import android.os.Bundle;
 import android.text.TextUtils;
 import android.view.LayoutInflater;
@@ -12,6 +13,7 @@
 
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
+import androidx.annotation.RequiresApi;
 import androidx.annotation.StringRes;
 import androidx.core.content.ContextCompat;
 import androidx.fragment.app.FragmentActivity;
@@ -41,9 +43,18 @@ public final class WelcomeFragment extends BaseRegistrationFragment {
                                                                         Manifest.permission.WRITE_EXTERNAL_STORAGE,
                                                                         Manifest.permission.READ_EXTERNAL_STORAGE,
                                                                         Manifest.permission.READ_PHONE_STATE };
+  @RequiresApi(26)
+  private static final            String[]       PERMISSIONS_API_26 = { Manifest.permission.WRITE_CONTACTS,
+                                                                        Manifest.permission.READ_CONTACTS,
+                                                                        Manifest.permission.WRITE_EXTERNAL_STORAGE,
+                                                                        Manifest.permission.READ_EXTERNAL_STORAGE,
+                                                                        Manifest.permission.READ_PHONE_STATE,
+                                                                        Manifest.permission.READ_PHONE_NUMBERS };
+  @RequiresApi(26)
   private static final            String[]       PERMISSIONS_API_29 = { Manifest.permission.WRITE_CONTACTS,
                                                                         Manifest.permission.READ_CONTACTS,
-                                                                        Manifest.permission.READ_PHONE_STATE };
+                                                                        Manifest.permission.READ_PHONE_STATE,
+                                                                        Manifest.permission.READ_PHONE_NUMBERS };
   private static final @StringRes int            RATIONALE          = R.string.RegistrationActivity_signal_needs_access_to_your_contacts_and_media_in_order_to_connect_with_friends;
   private static final @StringRes int            RATIONALE_API_29   = R.string.RegistrationActivity_signal_needs_access_to_your_contacts_in_order_to_connect_with_friends;
   private static final            int[]          HEADERS            = { R.drawable.ic_contacts_white_48dp, R.drawable.ic_folder_white_48dp };
@@ -173,7 +184,7 @@ private void gatherInformationAndChooseBackup(@NonNull View view) {
   private void initializeNumber() {
     Optional<Phonenumber.PhoneNumber> localNumber = Optional.absent();
 
-    if (Permissions.hasAll(requireContext(), Manifest.permission.READ_PHONE_STATE)) {
+    if (Permissions.hasAll(requireContext(), Manifest.permission.READ_PHONE_STATE, Manifest.permission.READ_PHONE_NUMBERS)) {
       localNumber = Util.getDeviceNumber(requireContext());
     }
 
@@ -198,8 +209,15 @@ private boolean canUserSelectBackup() {
            !TextSecurePreferences.isBackupEnabled(requireContext());
   }
 
+  @SuppressLint("NewApi")
   private static String[] getContinuePermissions(boolean isUserSelectionRequired) {
-    return isUserSelectionRequired ? PERMISSIONS_API_29 : PERMISSIONS;
+    if (isUserSelectionRequired) {
+      return PERMISSIONS_API_29;
+    } else if (Build.VERSION.SDK_INT >= 26) {
+      return PERMISSIONS_API_26;
+    } else {
+      return PERMISSIONS;
+    }
   }
 
   private static @StringRes int getContinueRationale(boolean isUserSelectionRequired) {