Skip to content

Commit

Permalink
Check callManager reference is still valid in ListenableFutureTask ca…
Browse files Browse the repository at this point in the history
…llbacks.
  • Loading branch information
cbrune-signal authored and greyson-signal committed Feb 26, 2020
1 parent 58b7612 commit 1bae79a
Showing 1 changed file with 18 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1456,30 +1456,36 @@ private class SendCallMessageListener<V> extends StateAwareListener<V> {

@Override
public void onSuccessContinue(V result) {
try {
callManager.messageSent(getCallId());
} catch (CallException e) {
callFailure("callManager.messageSent() failed: ", e);
if (callManager != null) {
try {
callManager.messageSent(getCallId());
} catch (CallException e) {
callFailure("callManager.messageSent() failed: ", e);
}
}
}

@Override
public void onStateChangeContinue() {
try {
callManager.messageSent(getCallId());
} catch (CallException e) {
callFailure("callManager.messageSent() failed: ", e);
if (callManager != null) {
try {
callManager.messageSent(getCallId());
} catch (CallException e) {
callFailure("callManager.messageSent() failed: ", e);
}
}
}

@Override
public void onFailureContinue(Throwable error) {
Log.w(TAG, error);

try {
callManager.messageSendFailure(getCallId());
} catch (CallException e) {
callFailure("callManager.messageSendFailure() failed: ", e);
if (callManager != null) {
try {
callManager.messageSendFailure(getCallId());
} catch (CallException e) {
callFailure("callManager.messageSendFailure() failed: ", e);
}
}

if (activePeer == null) {
Expand Down

0 comments on commit 1bae79a

Please sign in to comment.