Clip reactions mask if the view falls below the input panel.

signalapp · Feb 6, 2020 · 21cf390 · 21cf390
1 parent 5e59f77
commit 21cf390
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/MaskView.java b/app/src/main/java/org/thoughtcrime/securesms/components/MaskView.java
@@ -74,7 +74,9 @@ protected void onDraw(@NonNull Canvas canvas) {
     target.getDrawingRect(drawingRect);
     activityContentView.offsetDescendantRectToMyCoords(target, drawingRect);
 
-    Bitmap mask       = Bitmap.createBitmap(target.getWidth(), target.getHeight(), Bitmap.Config.ARGB_8888);
+    drawingRect.bottom = Math.min(drawingRect.bottom, getBottom() - getPaddingBottom());
+
+    Bitmap mask       = Bitmap.createBitmap(target.getWidth(), drawingRect.height(), Bitmap.Config.ARGB_8888);
     Canvas maskCanvas = new Canvas(mask);
 
     target.draw(maskCanvas);

diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationActivity.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationActivity.java
@@ -516,6 +516,10 @@ public void onConfigurationChanged(Configuration newConfig) {
     if (emojiDrawerStub.resolved() && container.getCurrentInput() == emojiDrawerStub.get()) {
       container.hideAttachedInput(true);
     }
+
+    if (reactionOverlay != null && reactionOverlay.isShowing()) {
+      reactionOverlay.hide();
+    }
   }
 
   @Override
@@ -2797,7 +2801,7 @@ public void handleReaction(@NonNull View maskTarget,
   {
     reactionOverlay.setOnToolbarItemClickedListener(toolbarListener);
     reactionOverlay.setOnHideListener(onHideListener);
-    reactionOverlay.show(this, maskTarget, messageRecord);
+    reactionOverlay.show(this, maskTarget, messageRecord, inputPanel.getMeasuredHeight());
   }
 
   @Override

diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationReactionOverlay.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationReactionOverlay.java
@@ -129,7 +129,7 @@ protected void onFinishInflate() {
     initAnimators();
   }
 
-  public void show(@NonNull Activity activity, @NonNull View maskTarget, @NonNull MessageRecord messageRecord) {
+  public void show(@NonNull Activity activity, @NonNull View maskTarget, @NonNull MessageRecord messageRecord, int maskPaddingBottom) {
 
     if (overlayState != OverlayState.HIDDEN) {
       return;
@@ -168,6 +168,7 @@ public void show(@NonNull Activity activity, @NonNull View maskTarget, @NonNull
     verticalScrubBoundary.update(lastSeenDownPoint.y - distanceFromTouchDownPointToTopOfScrubberDeadZone,
                                  lastSeenDownPoint.y + distanceFromTouchDownPointToBottomOfScrubberDeadZone);
 
+    maskView.setPadding(0, 0, 0, maskPaddingBottom);
     maskView.setTarget(maskTarget);
 
     hideAnimatorSet.end();
@@ -177,7 +178,7 @@ public void show(@NonNull Activity activity, @NonNull View maskTarget, @NonNull
     if (Build.VERSION.SDK_INT >= 21) {
       this.activity = activity;
       originalStatusBarColor = activity.getWindow().getStatusBarColor();
-      activity.getWindow().setStatusBarColor(ContextCompat.getColor(activity, R.color.core_grey_45));
+      activity.getWindow().setStatusBarColor(ContextCompat.getColor(activity, R.color.action_mode_status_bar));
     }
   }