Improve timer event generation from GV2 sync messages.

signalapp · Jan 20, 2023 · 269a2e2 · 269a2e2
1 parent 73b453b
commit 269a2e2
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/app/src/main/java/org/thoughtcrime/securesms/messages/MessageContentProcessor.java b/app/src/main/java/org/thoughtcrime/securesms/messages/MessageContentProcessor.java
@@ -2002,10 +2002,17 @@ private void handleStoryMessage(@NonNull SignalServiceContent content, @NonNull
   }
 
   private long handleSynchronizeSentExpirationUpdate(@NonNull SentTranscriptMessage message)
-      throws MmsException, BadGroupIdException
+      throws MmsException
   {
     log(message.getTimestamp(), "Synchronize sent expiration update.");
 
+    Optional<GroupId> groupId = getSyncMessageDestination(message).getGroupId();
+
+    if (groupId.isPresent() && groupId.get().isV2()) {
+      warn(String.valueOf(message.getTimestamp()), "Expiration update received for GV2. Ignoring.");
+      return -1;
+    }
+
     MessageTable database  = SignalDatabase.messages();
     Recipient    recipient = getSyncMessageDestination(message);
 
@@ -2034,9 +2041,9 @@ private long handleSynchronizeSentStoryReply(@NonNull SentTranscriptMessage mess
     try {
       Optional<SignalServiceDataMessage.Reaction> reaction             = message.getDataMessage().get().getReaction();
       ParentStoryId                               parentStoryId;
-      SignalServiceDataMessage.StoryContext storyContext = message.getDataMessage().get().getStoryContext().get();
-      MessageTable                          database     = SignalDatabase.messages();
-      Recipient                             recipient    = getSyncMessageDestination(message);
+      SignalServiceDataMessage.StoryContext       storyContext         = message.getDataMessage().get().getStoryContext().get();
+      MessageTable                                database             = SignalDatabase.messages();
+      Recipient                                   recipient            = getSyncMessageDestination(message);
       QuoteModel                                  quoteModel           = null;
       long                                        expiresInMillis      = 0L;
       RecipientId                                 storyAuthorRecipient = RecipientId.from(storyContext.getAuthorServiceId());
@@ -2267,8 +2274,8 @@ private long handleSynchronizeSentMediaMessage(@NonNull SentTranscriptMessage me
   {
     log(envelopeTimestamp, "Synchronize sent media message for " + message.getTimestamp());
 
-    MessageTable database   = SignalDatabase.messages();
-    Recipient    recipients = getSyncMessageDestination(message);
+    MessageTable                database        = SignalDatabase.messages();
+    Recipient                   recipients      = getSyncMessageDestination(message);
     Optional<QuoteModel>        quote           = getValidatedQuote(message.getDataMessage().get().getQuote());
     Optional<Attachment>        sticker         = getStickerAttachment(message.getDataMessage().get().getSticker());
     Optional<List<Contact>>     sharedContacts  = getContacts(message.getDataMessage().get().getSharedContacts());