Disable PIN requirement for new registrations.

signalapp · Feb 26, 2020 · 5158a15 · 5158a15
1 parent 1bae79a
commit 5158a15
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/app/src/main/java/org/thoughtcrime/securesms/PassphraseRequiredActionBarActivity.java b/app/src/main/java/org/thoughtcrime/securesms/PassphraseRequiredActionBarActivity.java
@@ -185,7 +185,9 @@ private int getApplicationState(boolean locked) {
   }
 
   private boolean userMustSetKbsPin() {
-    return !SignalStore.registrationValues().isRegistrationComplete() && !PinUtil.userHasPin(this);
+    // TODO [greyson] [pins] Maybe re-enable in the future
+//    return !SignalStore.registrationValues().isRegistrationComplete() && !PinUtil.userHasPin(this);
+    return false;
   }
 
   private boolean userMustSetProfileName() {

diff --git a/app/src/main/java/org/thoughtcrime/securesms/keyvalue/KbsValues.java b/app/src/main/java/org/thoughtcrime/securesms/keyvalue/KbsValues.java
@@ -129,6 +129,6 @@ public void setKeyboardType(@NonNull PinKeyboardType keyboardType) {
   }
 
   public boolean hasMigratedToPinsForAll() {
-    return store.getString(KEYBOARD_TYPE, null) != null;
+    return store.getString(KEYBOARD_TYPE, null) != null && store.getBoolean(V2_LOCK_ENABLED, false);
   }
 }
diff --git a/app/src/main/java/org/thoughtcrime/securesms/keyvalue/RegistrationValues.java b/app/src/main/java/org/thoughtcrime/securesms/keyvalue/RegistrationValues.java
@@ -17,7 +17,8 @@ public final class RegistrationValues {
   public synchronized void onNewInstall() {
     store.beginWrite()
          .putBoolean(REGISTRATION_COMPLETE, false)
-         .putBoolean(PIN_REQUIRED, true)
+         // TODO [greyson] [pins] Maybe re-enable in the future
+//         .putBoolean(PIN_REQUIRED, true)
          .commit();
   }
 

diff --git a/app/src/main/java/org/thoughtcrime/securesms/megaphone/PinsForAllSchedule.java b/app/src/main/java/org/thoughtcrime/securesms/megaphone/PinsForAllSchedule.java
@@ -26,7 +26,7 @@ class PinsForAllSchedule implements MegaphoneSchedule {
 
   static boolean shouldDisplayFullScreen(long firstVisible, long currentTime) {
     return false;
-    // TODO [greyson]
+    // TODO [greyson] [pins] Maybe re-enable if we ever do a blocking flow again
 //    if (pinCreationFailedDuringRegistration()) {
 //      return true;
 //    }
@@ -74,6 +74,10 @@ private static boolean isEnabled() {
       return false;
     }
 
+    if (SignalStore.kbsValues().hasMigratedToPinsForAll()) {
+      return false;
+    }
+
     return FeatureFlags.pinsForAll();
   }