Change position of GroupsV2 leave update message.

signalapp · Jul 28, 2020 · 745a7f7 · 745a7f7
1 parent 8cb9ab3
commit 745a7f7
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 2 deletions.
diff --git a/...rc/main/java/org/thoughtcrime/securesms/database/model/GroupsV2UpdateMessageProducer.java b/...rc/main/java/org/thoughtcrime/securesms/database/model/GroupsV2UpdateMessageProducer.java
@@ -82,7 +82,7 @@ List<UpdateDescription> describeChanges(@NonNull DecryptedGroupChange change) {
 
     if (change.getEditor().isEmpty() || UuidUtil.UNKNOWN_UUID.equals(UuidUtil.fromByteString(change.getEditor()))) {
       describeUnknownEditorMemberAdditions(change, updates);
-      describeUnknownEditorMemberRemovals(change, updates);
+
       describeUnknownEditorModifyMemberRoles(change, updates);
       describeUnknownEditorInvitations(change, updates);
       describeUnknownEditorRevokedInvitations(change, updates);
@@ -93,13 +93,15 @@ List<UpdateDescription> describeChanges(@NonNull DecryptedGroupChange change) {
       describeUnknownEditorNewAttributeAccess(change, updates);
       describeUnknownEditorNewMembershipAccess(change, updates);
 
+      describeUnknownEditorMemberRemovals(change, updates);
+
       if (updates.isEmpty()) {
         describeUnknownEditorUnknownChange(updates);
       }
 
     } else {
       describeMemberAdditions(change, updates);
-      describeMemberRemovals(change, updates);
+
       describeModifyMemberRoles(change, updates);
       describeInvitations(change, updates);
       describeRevokedInvitations(change, updates);
@@ -110,6 +112,8 @@ List<UpdateDescription> describeChanges(@NonNull DecryptedGroupChange change) {
       describeNewAttributeAccess(change, updates);
       describeNewMembershipAccess(change, updates);
 
+      describeMemberRemovals(change, updates);
+
       if (updates.isEmpty()) {
         describeUnknownChange(change, updates);
       }

diff --git a/...est/java/org/thoughtcrime/securesms/database/model/GroupsV2UpdateMessageProducerTest.java b/...est/java/org/thoughtcrime/securesms/database/model/GroupsV2UpdateMessageProducerTest.java
@@ -767,6 +767,30 @@ public void multiple_changes() {
       "Alice changed who can edit group membership to \"All members\".")));
   }
 
+  @Test
+  public void multiple_changes_leave_and_promote() {
+    DecryptedGroupChange change = changeBy(alice)
+                                    .deleteMember(alice)
+                                    .promoteToAdmin(bob)
+                                    .build();
+
+    assertThat(describeChange(change), is(Arrays.asList(
+      "Alice made Bob an admin.",
+      "Alice left the group.")));
+  }
+
+  @Test
+  public void multiple_changes_leave_and_promote_by_unknown() {
+    DecryptedGroupChange change = changeByUnknown()
+                                    .deleteMember(alice)
+                                    .promoteToAdmin(bob)
+                                    .build();
+
+    assertThat(describeChange(change), is(Arrays.asList(
+      "Bob is now an admin.",
+      "Alice is no longer in the group.")));
+  }
+
   @Test
   public void multiple_changes_by_unknown() {
     DecryptedGroupChange change = changeByUnknown()
@@ -785,6 +809,22 @@ public void multiple_changes_by_unknown() {
       "Who can edit group membership has been changed to \"All members\".")));
   }
 
+  @Test
+  public void multiple_changes_join_and_leave_by_unknown() {
+    DecryptedGroupChange change = changeByUnknown()
+                                    .addMember(alice)
+                                    .promoteToAdmin(alice)
+                                    .deleteMember(alice)
+                                    .title("Updated title")
+                                    .build();
+
+    assertThat(describeChange(change), is(Arrays.asList(
+      "Alice joined the group.",
+      "Alice is now an admin.",
+      "The group name has changed to \"Updated title\".",
+      "Alice is no longer in the group.")));
+  }
+
   // Group state without a change record
 
   @Test