Fix incorrect notification sound when channel is set to silent.

Fixes #12317
signalapp · Jul 11, 2022 · 748dbc2 · 748dbc2
1 parent e80df64
commit 748dbc2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/...s/components/settings/conversation/sounds/custom/CustomNotificationsSettingsRepository.kt b/...s/components/settings/conversation/sounds/custom/CustomNotificationsSettingsRepository.kt
@@ -25,7 +25,8 @@ class CustomNotificationsSettingsRepository(context: Context) {
         val recipient = Recipient.resolved(recipientId)
         val database = SignalDatabase.recipients
         if (recipient.notificationChannel != null) {
-          database.setMessageRingtone(recipient.id, NotificationChannels.getMessageRingtone(context, recipient))
+          val ringtoneUri: Uri? = NotificationChannels.getMessageRingtone(context, recipient)
+          database.setMessageRingtone(recipient.id, if (ringtoneUri == Uri.EMPTY) null else ringtoneUri)
           database.setMessageVibrate(recipient.id, RecipientDatabase.VibrateState.fromBoolean(NotificationChannels.getMessageVibrate(context, recipient)))
         }
       }

diff --git a/app/src/main/java/org/thoughtcrime/securesms/notifications/NotificationChannels.java b/app/src/main/java/org/thoughtcrime/securesms/notifications/NotificationChannels.java
@@ -296,7 +296,8 @@ public static synchronized void updateMessagesLedColor(@NonNull Context context,
       return null;
     }
 
-    return channel.getSound();
+    Uri channelSound = channel.getSound();
+    return channelSound != null ? channelSound : Uri.EMPTY;
   }
 
   /**

diff --git a/app/src/main/java/org/thoughtcrime/securesms/notifications/v2/NotificationFactory.kt b/app/src/main/java/org/thoughtcrime/securesms/notifications/v2/NotificationFactory.kt
@@ -274,7 +274,7 @@ object NotificationFactory {
       recipient.messageRingtone ?: SignalStore.settings().messageNotificationSound
     }
 
-    if (uri.toString().isEmpty()) {
+    if (uri == Uri.EMPTY || uri.toString().isEmpty()) {
       Log.d(TAG, "ringtone uri is empty")
       return
     }