Revert "Do not set or read quote author phone number."

This reverts commit 936e772.
signalapp · Nov 5, 2020 · 872f935 · 872f935
1 parent 0ed1f73
commit 872f935
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/...ervice/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java b/...ervice/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java
@@ -584,6 +584,11 @@ private byte[] createMessageContent(SignalServiceDataMessage message) throws IOE
         quoteBuilder.setAuthorUuid(message.getQuote().get().getAuthor().getUuid().get().toString());
       }
 
+      // TODO [Alan] PhoneNumberPrivacy: Do not set this number
+      if (message.getQuote().get().getAuthor().getNumber().isPresent()) {
+        quoteBuilder.setAuthorE164(message.getQuote().get().getAuthor().getNumber().get());
+      }
+
       if (!message.getQuote().get().getMentions().isEmpty()) {
         for (SignalServiceDataMessage.Mention mention : message.getQuote().get().getMentions()) {
           quoteBuilder.addBodyRanges(DataMessage.BodyRange.newBuilder()

diff --git a/...ice/src/main/java/org/whispersystems/signalservice/api/messages/SignalServiceContent.java b/...ice/src/main/java/org/whispersystems/signalservice/api/messages/SignalServiceContent.java
@@ -660,16 +660,16 @@ private static SignalServiceDataMessage.Quote createQuote(SignalServiceProtos.Da
                                                                           attachment.hasThumbnail() ? createAttachmentPointer(attachment.getThumbnail()) : null));
     }
 
-    if (SignalServiceAddress.isValidAddress(content.getQuote().getAuthorUuid(), null)) {
-      SignalServiceAddress address = new SignalServiceAddress(UuidUtil.parseOrNull(content.getQuote().getAuthorUuid()), null);
+    if (SignalServiceAddress.isValidAddress(content.getQuote().getAuthorUuid(), content.getQuote().getAuthorE164())) {
+      SignalServiceAddress address = new SignalServiceAddress(UuidUtil.parseOrNull(content.getQuote().getAuthorUuid()), content.getQuote().getAuthorE164());
 
       return new SignalServiceDataMessage.Quote(content.getQuote().getId(),
                                                 address,
                                                 content.getQuote().getText(),
                                                 attachments,
                                                 createMentions(content.getQuote().getBodyRangesList(), content.getQuote().getText(), isGroupV2));
     } else {
-      Log.w(TAG, "Quote was missing author's UUID! Returning null.");
+      Log.w(TAG, "Quote was missing an author! Returning null.");
       return null;
     }
   }

diff --git a/libsignal/service/src/main/proto/SignalService.proto b/libsignal/service/src/main/proto/SignalService.proto
@@ -128,7 +128,7 @@ message DataMessage {
     }
 
     optional uint64           id          = 1;
-    // optional string           authorE164  = 2;
+    optional string           authorE164  = 2;
     optional string           authorUuid  = 5;
     optional string           text        = 3;
     repeated QuotedAttachment attachments = 4;