Fix strings in KBS PIN flow.

signalapp · Feb 3, 2020 · a6786e5 · a6786e5
1 parent 77caa9e
commit a6786e5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 15 deletions.
diff --git a/app/src/main/java/org/thoughtcrime/securesms/lock/v2/ConfirmKbsPinFragment.java b/app/src/main/java/org/thoughtcrime/securesms/lock/v2/ConfirmKbsPinFragment.java
@@ -32,9 +32,9 @@ protected void initializeViewStates() {
     args = ConfirmKbsPinFragmentArgs.fromBundle(requireArguments());
 
     if (args.getIsNewPin()) {
-      initializeViewStatesForNewPin();
+      initializeViewStatesForPinCreate();
     } else {
-      initializeViewStatesForPin();
+      initializeViewStatesForPinUpdate();
     }
   }
 
@@ -53,15 +53,15 @@ protected ConfirmKbsPinViewModel initializeViewModel() {
     return viewModel;
   }
 
-  private void initializeViewStatesForNewPin() {
-    getTitle().setText(R.string.CreateKbsPinFragment__create_a_new_pin);
+  private void initializeViewStatesForPinCreate() {
+    getTitle().setText(R.string.CreateKbsPinFragment__create_your_pin);
     getDescription().setText(R.string.ConfirmKbsPinFragment__confirm_your_pin);
     getKeyboardToggle().setVisibility(View.INVISIBLE);
     getLabel().setText("");
   }
 
-  private void initializeViewStatesForPin() {
-    getTitle().setText(R.string.CreateKbsPinFragment__create_your_pin);
+  private void initializeViewStatesForPinUpdate() {
+    getTitle().setText(R.string.CreateKbsPinFragment__create_a_new_pin);
     getDescription().setText(R.string.ConfirmKbsPinFragment__confirm_your_pin);
     getKeyboardToggle().setVisibility(View.INVISIBLE);
     getLabel().setText("");

diff --git a/app/src/main/java/org/thoughtcrime/securesms/lock/v2/CreateKbsPinFragment.java b/app/src/main/java/org/thoughtcrime/securesms/lock/v2/CreateKbsPinFragment.java
@@ -16,26 +16,25 @@ protected void initializeViewStates() {
     args = CreateKbsPinFragmentArgs.fromBundle(requireArguments());
 
     if (args.getIsNewPin()) {
-      initializeViewStatesForNewPin();
+      initializeViewStatesForPinCreate();
     } else {
-      initializeViewStatesForPin();
+      initializeViewStatesForPinUpdate();
     }
 
     getLabel().setText(getPinLengthRestrictionText(R.plurals.CreateKbsPinFragment__pin_must_be_at_least_digits));
     getConfirm().setEnabled(false);
   }
 
-  private void initializeViewStatesForPin() {
-    getTitle().setText(R.string.CreateKbsPinFragment__create_your_pin);
-    getDescription().setText(R.string.CreateKbsPinFragment__pins_add_an_extra_layer_of_security);
-
-  }
-
-  private void initializeViewStatesForNewPin() {
+  private void initializeViewStatesForPinUpdate() {
     getTitle().setText(R.string.CreateKbsPinFragment__create_a_new_pin);
     getDescription().setText(R.string.CreateKbsPinFragment__because_youre_still_logged_in);
   }
 
+  private void initializeViewStatesForPinCreate() {
+    getTitle().setText(R.string.CreateKbsPinFragment__create_your_pin);
+    getDescription().setText(R.string.CreateKbsPinFragment__pins_add_an_extra_layer_of_security);
+  }
+
   @Override
   protected CreateKbsPinViewModel initializeViewModel() {
     CreateKbsPinViewModel viewModel = ViewModelProviders.of(this).get(CreateKbsPinViewModel.class);