Skip to content

Commit

Permalink
Enable video trimming feature by default.
Browse files Browse the repository at this point in the history
  • Loading branch information
alan-signal authored and greyson-signal committed Apr 3, 2020
1 parent 040e1fe commit b8e17e0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
player.setWindow(requireActivity().getWindow());
player.setVideoSource(slide, true);

if (FeatureFlags.videoTrimming() && MediaConstraints.isVideoTranscodeAvailable()) {
if (MediaConstraints.isVideoTranscodeAvailable()) {
hud = view.findViewById(R.id.video_editor_hud);
hud.setEventListener(this);
updateHud(data);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public final class FeatureFlags {
private static final String PINS_FOR_ALL = "android.pinsForAll";
private static final String PINS_MEGAPHONE_KILL_SWITCH = "android.pinsMegaphoneKillSwitch";
private static final String PROFILE_NAMES_MEGAPHONE = "android.profileNamesMegaphone";
private static final String VIDEO_TRIMMING = "android.videoTrimming.2";
private static final String STORAGE_SERVICE = "android.storageService.2";

/**
Expand All @@ -61,7 +60,6 @@ public final class FeatureFlags {
*/

private static final Set<String> REMOTE_CAPABLE = Sets.newHashSet(
VIDEO_TRIMMING,
PINS_FOR_ALL,
PINS_MEGAPHONE_KILL_SWITCH,
PROFILE_NAMES_MEGAPHONE,
Expand All @@ -87,7 +85,6 @@ public final class FeatureFlags {
* more burden on the reader to ensure that the app experience remains consistent.
*/
private static final Set<String> HOT_SWAPPABLE = Sets.newHashSet(
VIDEO_TRIMMING,
PINS_MEGAPHONE_KILL_SWITCH,
STORAGE_SERVICE
);
Expand Down Expand Up @@ -199,11 +196,6 @@ public static boolean profileNamesMegaphone() {
TextSecurePreferences.getFirstInstallVersion(ApplicationDependencies.getApplication()) < 600;
}

/** Allow trimming videos. */
public static boolean videoTrimming() {
return getValue(VIDEO_TRIMMING, false);
}

/** Whether or not we can actually restore data on a new installation. NOT remote-configurable. */
public static boolean storageServiceRestore() {
return false;
Expand Down

0 comments on commit b8e17e0

Please sign in to comment.