Skip to content

Commit

Permalink
Show PIN reminder for non-reglock users.
Browse files Browse the repository at this point in the history
  • Loading branch information
@greyson-signal
greyson-signal committed Apr 28, 2020
1 parent e99af75 commit bdd48fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/src/main/java/org/thoughtcrime/securesms/megaphone/SignalPinReminderSchedule.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ final class SignalPinReminderSchedule implements MegaphoneSchedule {

@Override
public boolean shouldDisplay(int seenCount, long lastSeen, long firstVisible, long currentTime) {
if (!SignalStore.kbsValues().isV2RegistrationLockEnabled()) {
if (!SignalStore.kbsValues().hasPin()) {
return false;
}

Expand Down

2 comments on commit bdd48fd

@ashafer01
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the ! at the start of this condition is now erroneous. I don't have a PIN set but i'm getting a "create a pin" window blocking much of my screen, and it appeared on its own "2 days" after last app update.

@greyson-signal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the dialog that prompts you to recall an already-created PIN, so the logic here is correct. You can't be asked to recall a PIN if you don't have one.

Please sign in to comment.