Fix some PinState bugs.

signalapp · Apr 24, 2020 · cca85bf · cca85bf
1 parent 575caa5
commit cca85bf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/app/src/main/java/org/thoughtcrime/securesms/pin/PinState.java b/app/src/main/java/org/thoughtcrime/securesms/pin/PinState.java
@@ -181,6 +181,12 @@ public static synchronized void onPinChangedOrCreated(@NonNull Context context,
   @WorkerThread
   public static synchronized void onEnableRegistrationLockForUserWithPin() throws IOException {
     Log.i(TAG, "onEnableRegistrationLockForUserWithPin()");
+
+    if (getState() == State.PIN_WITH_REGISTRATION_LOCK_ENABLED) {
+      Log.i(TAG, "Registration lock already enabled. Skipping.");
+      return;
+    }
+
     assertState(State.PIN_WITH_REGISTRATION_LOCK_DISABLED);
 
     SignalStore.kbsValues().setV2RegistrationLockEnabled(false);
@@ -198,6 +204,12 @@ public static synchronized void onEnableRegistrationLockForUserWithPin() throws
   @WorkerThread
   public static synchronized void onDisableRegistrationLockForUserWithPin() throws IOException {
     Log.i(TAG, "onDisableRegistrationLockForUserWithPin()");
+
+    if (getState() == State.PIN_WITH_REGISTRATION_LOCK_DISABLED) {
+      Log.i(TAG, "Registration lock already disabled. Skipping.");
+      return;
+    }
+
     assertState(State.PIN_WITH_REGISTRATION_LOCK_ENABLED);
 
     SignalStore.kbsValues().setV2RegistrationLockEnabled(true);

diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/FeatureFlags.java b/app/src/main/java/org/thoughtcrime/securesms/util/FeatureFlags.java
@@ -194,6 +194,7 @@ public static synchronized boolean usernames() {
   public static boolean pinsForAll() {
     return SignalStore.registrationValues().pinWasRequiredAtRegistration() ||
            SignalStore.kbsValues().isV2RegistrationLockEnabled()           ||
+           SignalStore.kbsValues().hasPin()                                ||
            pinsForAllMandatory()                                           ||
            getValue(PINS_FOR_ALL_LEGACY, false)                            ||
            getValue(PINS_FOR_ALL, false);