Fix inset issues in landscape.

signalapp · Jan 24, 2021 · d8060b3 · d8060b3
1 parent f42ec53
commit d8060b3
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 7 deletions.
diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/InsetAwareConstraintLayout.java b/app/src/main/java/org/thoughtcrime/securesms/components/InsetAwareConstraintLayout.java
@@ -33,6 +33,8 @@ public InsetAwareConstraintLayout(@NonNull Context context, @Nullable AttributeS
   protected boolean fitSystemWindows(Rect insets) {
     Guideline statusBarGuideline     = findViewById(R.id.status_bar_guideline);
     Guideline navigationBarGuideline = findViewById(R.id.navigation_bar_guideline);
+    Guideline parentStartGuideline   = findViewById(R.id.parent_start_guideline);
+    Guideline parentEndGuideline     = findViewById(R.id.parent_end_guideline);
 
     if (statusBarGuideline != null) {
       statusBarGuideline.setGuidelineBegin(insets.top);
@@ -42,6 +44,14 @@ protected boolean fitSystemWindows(Rect insets) {
       navigationBarGuideline.setGuidelineEnd(insets.bottom);
     }
 
+    if (parentStartGuideline != null) {
+      parentStartGuideline.setGuidelineBegin(insets.left);
+    }
+
+    if (parentEndGuideline != null) {
+      parentEndGuideline.setGuidelineEnd(insets.right);
+    }
+
     return true;
   }
 }
diff --git a/app/src/main/res/layout/conversation_activity.xml b/app/src/main/res/layout/conversation_activity.xml
@@ -25,10 +25,11 @@
         tools:visibility="visible" />
 
     <com.google.android.material.appbar.AppBarLayout
-        app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toTopOf="@id/status_bar_guideline"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content">
+        android:layout_width="0dp"
+        android:layout_height="wrap_content"
+        app:layout_constraintStart_toStartOf="@id/parent_start_guideline"
+        app:layout_constraintEnd_toEndOf="@id/parent_end_guideline"
+        app:layout_constraintTop_toTopOf="@id/status_bar_guideline">
 
         <androidx.appcompat.widget.Toolbar
             android:id="@+id/toolbar"
@@ -76,10 +77,12 @@
 
     <org.thoughtcrime.securesms.components.InputAwareLayout
         android:id="@+id/layout_container"
-        android:layout_width="match_parent"
+        android:layout_width="0dp"
         android:layout_height="0dp"
         app:layout_constraintTop_toTopOf="@id/status_bar_guideline"
-        app:layout_constraintBottom_toBottomOf="@id/navigation_bar_guideline">
+        app:layout_constraintBottom_toBottomOf="@id/navigation_bar_guideline"
+        app:layout_constraintStart_toStartOf="@id/parent_start_guideline"
+        app:layout_constraintEnd_toEndOf="@id/parent_end_guideline">
 
         <LinearLayout
             android:id="@+id/conversation_container"

diff --git a/app/src/main/res/layout/conversation_reaction_scrubber.xml b/app/src/main/res/layout/conversation_reaction_scrubber.xml
@@ -3,10 +3,12 @@
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/conversation_reaction_scrubber"
-    android:layout_width="match_parent"
+    android:layout_width="0dp"
     android:layout_height="0dp"
     app:layout_constraintTop_toTopOf="@+id/status_bar_guideline"
     app:layout_constraintBottom_toBottomOf="@+id/navigation_bar_guideline"
+    app:layout_constraintStart_toStartOf="@+id/parent_start_guideline"
+    app:layout_constraintEnd_toEndOf="@+id/parent_end_guideline"
     android:elevation="1000dp"
     android:visibility="gone"
     tools:visibility="visible">

diff --git a/app/src/main/res/layout/system_ui_guidelines.xml b/app/src/main/res/layout/system_ui_guidelines.xml
@@ -14,4 +14,18 @@
         android:layout_height="wrap_content"
         android:orientation="horizontal"
         tools:layout_constraintGuide_end="48dp" />
+
+    <androidx.constraintlayout.widget.Guideline
+        android:id="@+id/parent_start_guideline"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:orientation="vertical"
+        tools:layout_constraintGuide_begin="5dp" />
+
+    <androidx.constraintlayout.widget.Guideline
+        android:id="@+id/parent_end_guideline"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:orientation="vertical"
+        tools:layout_constraintGuide_end="5dp" />
 </merge>