Ensure Job factories pass the parameters to their created Jobs.

signalapp · Mar 16, 2021 · d83c3d3 · d83c3d3
1 parent 8f26d63
commit d83c3d3
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/app/src/main/java/org/thoughtcrime/securesms/jobmanager/JobInstantiator.java b/app/src/main/java/org/thoughtcrime/securesms/jobmanager/JobInstantiator.java
@@ -14,8 +14,15 @@ class JobInstantiator {
   }
 
   public @NonNull Job instantiate(@NonNull String jobFactoryKey, @NonNull Job.Parameters parameters, @NonNull Data data) {
-    if (jobFactories.containsKey(jobFactoryKey)) {
-      return jobFactories.get(jobFactoryKey).create(parameters, data);
+    Job.Factory factory = jobFactories.get(jobFactoryKey);
+    if (factory != null) {
+      Job job = factory.create(parameters, data);
+
+      if (!job.getId().equals(parameters.getId())) {
+        throw new AssertionError("Parameters not supplied to job during creation");
+      }
+
+      return job;
     } else {
       throw new IllegalStateException("Tried to instantiate a job with key '" + jobFactoryKey + "', but no matching factory was found.");
     }