Skip to content

Commit

Permalink
Timeline: Add role='row' to each element item rendered
Browse files Browse the repository at this point in the history
  • Loading branch information
scottnonnenberg-signal committed Sep 18, 2019
1 parent 0e25b40 commit 1984ffc
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions ts/components/conversation/Timeline.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -510,13 +510,13 @@ export class Timeline extends React.PureComponent<Props, State> {

if (!haveOldest && row === 0) {
rowContents = (
<div data-row={row} style={styleWithWidth}>
<div data-row={row} style={styleWithWidth} role="row">
{renderLoadingRow(id)}
</div>
);
} else if (oldestUnreadRow === row) {
rowContents = (
<div data-row={row} style={styleWithWidth}>
<div data-row={row} style={styleWithWidth} role="row">
{renderLastSeenIndicator(id)}
</div>
);
Expand All @@ -526,6 +526,7 @@ export class Timeline extends React.PureComponent<Props, State> {
data-row={row}
className="module-timeline__message-container"
style={styleWithWidth}
role="row"
>
{renderTypingBubble(id)}
</div>
Expand All @@ -544,6 +545,7 @@ export class Timeline extends React.PureComponent<Props, State> {
data-row={row}
className="module-timeline__message-container"
style={styleWithWidth}
role="row"
>
{renderItem(messageId, this.props)}
</div>
Expand Down

0 comments on commit 1984ffc

Please sign in to comment.