Update TypeScript, Prettier and typescript-eslint for new TypeScript …

…3.8 syntax
signalapp · Nov 23, 2020 · 2688443 · 2688443
1 parent 5758ed4
commit 2688443
Show file tree

Hide file tree

Showing 65 changed files with 286 additions and 185 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -15,6 +15,12 @@ const rules = {
     },
   ],
 
+  // Overrides recommended by typescript-eslint
+  //   https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.0.0
+  '@typescript-eslint/no-redeclare': 'error',
+  '@typescript-eslint/no-shadow': 'error',
+  'no-shadow': 'off',
+
   // prevents us from accidentally checking in exclusive tests (`.only`):
   'mocha/no-exclusive-tests': 'error',
 

diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
@@ -13,11 +13,11 @@ Lastly, be sure to preview your issue before saving. Thanks!
 -->
 
 - [ ] I have searched open and closed issues for duplicates
-  <!--
-    You can search all issues here:
-      https://github.com/signalapp/Signal-Desktop/issues?utf8=%E2%9C%93&q=is%3Aissue
-    Replace [ ] with [X] once you've searched
-  -->
+<!--
+  You can search all issues here:
+    https://github.com/signalapp/Signal-Desktop/issues?utf8=%E2%9C%93&q=is%3Aissue
+  Replace [ ] with [X] once you've searched
+-->
 
 ---
 

diff --git a/.prettierrc.js b/.prettierrc.js
@@ -3,5 +3,6 @@
 
 module.exports = {
   singleQuote: true,
+  arrowParens: 'avoid',
   trailingComma: 'es5',
 };
diff --git a/js/database.js b/js/database.js
@@ -4,7 +4,7 @@
 /* global Whisper: false */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
   window.Whisper.Database = window.Whisper.Database || {};
   window.Whisper.Database.id = window.Whisper.Database.id || 'signal';

diff --git a/js/deletes.js b/js/deletes.js
@@ -11,7 +11,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
   Whisper.Deletes = new (Backbone.Collection.extend({
     forMessage(message) {

diff --git a/js/delivery_receipts.js b/js/delivery_receipts.js
@@ -12,7 +12,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   Whisper.DeliveryReceipts = new (Backbone.Collection.extend({

diff --git a/js/expiring_messages.js b/js/expiring_messages.js
@@ -8,7 +8,7 @@
 */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   async function destroyExpiredMessages() {

diff --git a/js/expiring_tap_to_view_messages.js b/js/expiring_tap_to_view_messages.js
@@ -8,7 +8,7 @@
 */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   async function eraseTapToViewMessages() {

diff --git a/js/keychange_listener.js b/js/keychange_listener.js
@@ -6,7 +6,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   Whisper.KeyChangeListener = {

diff --git a/js/libphonenumber-util.js b/js/libphonenumber-util.js
@@ -1,7 +1,7 @@
 // Copyright 2014-2020 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
 
-(function() {
+(function () {
   'use strict';
 
   /*
@@ -12,7 +12,7 @@
 
   window.libphonenumber = window.libphonenumber || {};
   window.libphonenumber.util = {
-    getRegionCodeForNumber: function(number) {
+    getRegionCodeForNumber: function (number) {
       try {
         var parsedNumber = libphonenumber.parse(number);
         return libphonenumber.getRegionCodeForNumber(parsedNumber);
@@ -21,20 +21,20 @@
       }
     },
 
-    splitCountryCode: function(number) {
+    splitCountryCode: function (number) {
       var parsedNumber = libphonenumber.parse(number);
       return {
         country_code: parsedNumber.values_[1],
         national_number: parsedNumber.values_[2],
       };
     },
 
-    getCountryCode: function(regionCode) {
+    getCountryCode: function (regionCode) {
       var cc = libphonenumber.getCountryCodeForRegion(regionCode);
       return cc !== 0 ? cc : '';
     },
 
-    parseNumber: function(number, defaultRegionCode) {
+    parseNumber: function (number, defaultRegionCode) {
       try {
         var parsedNumber = libphonenumber.parse(number, defaultRegionCode);
 
@@ -53,7 +53,7 @@
       }
     },
 
-    getAllRegionCodes: function() {
+    getAllRegionCodes: function () {
       return {
         AD: 'Andorra',
         AE: 'United Arab Emirates',

diff --git a/js/message_controller.js b/js/message_controller.js
@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   const messageLookup = Object.create(null);

diff --git a/js/message_requests.js b/js/message_requests.js
@@ -10,7 +10,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
   Whisper.MessageRequests = new (Backbone.Collection.extend({
     forConversation(conversation) {

diff --git a/js/models/blockedNumbers.js b/js/models/blockedNumbers.js
@@ -4,7 +4,7 @@
 /* global storage, _ */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   const BLOCKED_NUMBERS_ID = 'blocked';
   const BLOCKED_UUIDS_ID = 'blocked-uuids';
   const BLOCKED_GROUPS_ID = 'blocked-groups';

diff --git a/js/modules/attachment_downloads.js b/js/modules/attachment_downloads.js
@@ -199,8 +199,9 @@ async function _runJob(job) {
       logger.warn(
         `_runJob: Got 404 from server for CDN ${
           attachment.cdnNumber
-        }, marking attachment ${attachment.cdnId ||
-          attachment.cdnKey} from message ${message.idForLogging()} as permanent error`
+        }, marking attachment ${
+          attachment.cdnId || attachment.cdnKey
+        } from message ${message.idForLogging()} as permanent error`
       );
 
       await _finishJob(message, id);

diff --git a/js/notifications.js b/js/notifications.js
@@ -11,7 +11,7 @@
 /* global _: false */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   // The keys and values don't match here. This is because the values correspond to old

diff --git a/js/reactions.js b/js/reactions.js
@@ -11,7 +11,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
   Whisper.Reactions = new (Backbone.Collection.extend({
     forMessage(message) {

diff --git a/js/read_receipts.js b/js/read_receipts.js
@@ -12,7 +12,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
   Whisper.ReadReceipts = new (Backbone.Collection.extend({
     forMessage(conversation, message) {

diff --git a/js/read_syncs.js b/js/read_syncs.js
@@ -10,7 +10,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
   Whisper.ReadSyncs = new (Backbone.Collection.extend({
     forMessage(message) {

diff --git a/js/reliable_trigger.js b/js/reliable_trigger.js
@@ -6,7 +6,7 @@
 // This file was taken from Backbone and then modified. It does not conform to this
 //   project's standards.
 
-(function() {
+(function () {
   'use strict';
 
   // Note: this is all the code required to customize Backbone's trigger() method to make
@@ -32,7 +32,7 @@
   // Implement fancy features of the Events API such as multiple event
   // names `"change blur"` and jQuery-style event maps `{change: action}`
   // in terms of the existing API.
-  const eventsApi = function(obj, action, name, rest) {
+  const eventsApi = function (obj, action, name, rest) {
     if (!name) return true;
 
     // Handle event maps.
@@ -58,14 +58,14 @@
   // A difficult-to-believe, but optimized internal dispatch function for
   // triggering events. Tries to keep the usual cases speedy (most internal
   // Backbone events have 3 arguments).
-  const triggerEvents = function(events, name, args) {
+  const triggerEvents = function (events, name, args) {
     let ev,
       i = -1,
       l = events.length,
       a1 = args[0],
       a2 = args[1],
       a3 = args[2];
-    const logError = function(error) {
+    const logError = function (error) {
       window.log.error(
         'Model caught error triggering',
         name,

diff --git a/js/rotate_signed_prekey_listener.js b/js/rotate_signed_prekey_listener.js
@@ -4,7 +4,7 @@
 /* global Whisper, storage, getAccountManager */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
   const ROTATION_INTERVAL = 48 * 60 * 60 * 1000;
   let timeout;

diff --git a/js/signal_protocol_store.js b/js/signal_protocol_store.js
@@ -7,7 +7,7 @@
 /* eslint-disable no-proto */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   const TIMESTAMP_THRESHOLD = 5 * 1000; // 5 seconds
   const Direction = {
     SENDING: 1,

diff --git a/js/storage.js b/js/storage.js
@@ -5,7 +5,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   let ready = false;

diff --git a/js/view_syncs.js b/js/view_syncs.js
@@ -10,7 +10,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
   Whisper.ViewSyncs = new (Backbone.Collection.extend({
     forMessage(message) {

diff --git a/js/views/app_view.js b/js/views/app_view.js
@@ -6,7 +6,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   function resolveTheme() {

diff --git a/js/views/banner_view.js b/js/views/banner_view.js
@@ -4,7 +4,7 @@
 /* global Whisper */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   Whisper.BannerView = Whisper.View.extend({

diff --git a/js/views/clear_data_view.js b/js/views/clear_data_view.js
@@ -7,7 +7,7 @@
 /* eslint-disable no-new */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
   const { Logs } = window.Signal;
 

diff --git a/js/views/confirmation_dialog_view.js b/js/views/confirmation_dialog_view.js
@@ -4,7 +4,7 @@
 /* global Backbone, Whisper, i18n */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   Whisper.ConfirmationDialogView = Whisper.View.extend({

diff --git a/js/views/contact_list_view.js b/js/views/contact_list_view.js
@@ -5,7 +5,7 @@
 /* global textsecure: false */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   Whisper.ContactListView = Whisper.ListView.extend({

diff --git a/js/views/debug_log_view.js b/js/views/debug_log_view.js
@@ -5,7 +5,7 @@
 /* global Whisper: false */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   Whisper.LinkedCopiedToast = Whisper.ToastView.extend({
@@ -80,9 +80,7 @@
         });
         this.$('.loading').removeClass('loading');
         view.render();
-        this.$('.link')
-          .focus()
-          .select();
+        this.$('.link').focus().select();
       } catch (error) {
         window.log.error(
           'DebugLogView error:',

diff --git a/js/views/group_member_list_view.js b/js/views/group_member_list_view.js
@@ -4,7 +4,7 @@
 /* global Whisper, i18n */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   // TODO: take a title string which could replace the 'members' header

diff --git a/js/views/identicon_svg_view.js b/js/views/identicon_svg_view.js
@@ -4,7 +4,7 @@
 /* global Whisper, loadImage */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   /*

diff --git a/js/views/inbox_view.js b/js/views/inbox_view.js
@@ -9,7 +9,7 @@
 */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   Whisper.StickerPackInstallFailedToast = Whisper.ToastView.extend({

diff --git a/js/views/install_view.js b/js/views/install_view.js
@@ -6,7 +6,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   const Steps = {

diff --git a/js/views/key_verification_view.js b/js/views/key_verification_view.js
@@ -6,7 +6,7 @@
 /* eslint-disable more/no-then */
 
 // eslint-disable-next-line func-names
-(function() {
+(function () {
   window.Whisper = window.Whisper || {};
 
   Whisper.KeyVerificationPanelView = Whisper.View.extend({