getMembersCount: Return undefined when conversation has no members

signalapp · Feb 10, 2021 · 2957735 · 2957735
1 parent a8d7d71
commit 2957735
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ts/models/conversations.ts b/ts/models/conversations.ts
@@ -1412,9 +1412,9 @@ export class ConversationModel extends window.Backbone.Model<
     window.Signal.Data.updateConversation(this.attributes);
   }
 
-  getMembersCount(): number {
+  getMembersCount(): number | undefined {
     if (this.isPrivate()) {
-      return 1;
+      return undefined;
     }
 
     const memberList = this.get('membersV2') || this.get('members');
@@ -1429,7 +1429,7 @@ export class ConversationModel extends window.Backbone.Model<
       return temporaryMemberCount;
     }
 
-    return 0;
+    return undefined;
   }
 
   decrementMessageCount(): void {