More peeking of group calls to prevent out-of-date member info

Co-authored-by: Scott Nonnenberg <scott@signal.org>
signalapp · Apr 1, 2022 · 3ed5c36 · 3ed5c36
1 parent ee3a35d
commit 3ed5c36
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 2 deletions.
diff --git a/ts/components/conversation/Timeline.stories.tsx b/ts/components/conversation/Timeline.stories.tsx
@@ -417,6 +417,7 @@ const actions = () => ({
   unblurAvatar: action('unblurAvatar'),
 
   peekGroupCallForTheFirstTime: action('peekGroupCallForTheFirstTime'),
+  peekGroupCallIfItHasMembers: action('peekGroupCallIfItHasMembers'),
 });
 
 const renderItem = ({

diff --git a/ts/components/conversation/Timeline.tsx b/ts/components/conversation/Timeline.tsx
@@ -46,6 +46,7 @@ import {
   setScrollBottom,
 } from '../../util/scrollUtil';
 import { LastSeenIndicator } from './LastSeenIndicator';
+import { MINUTE } from '../../util/durations';
 
 const AT_BOTTOM_THRESHOLD = 15;
 const AT_BOTTOM_DETECTOR_STYLE = { height: AT_BOTTOM_THRESHOLD };
@@ -162,6 +163,7 @@ export type PropsActionsType = {
   onDelete: (conversationId: string) => unknown;
   onUnblock: (conversationId: string) => unknown;
   peekGroupCallForTheFirstTime: (conversationId: string) => unknown;
+  peekGroupCallIfItHasMembers: (conversationId: string) => unknown;
   removeMember: (conversationId: string) => unknown;
   selectMessage: (messageId: string, conversationId: string) => unknown;
   clearSelectedMessage: () => unknown;
@@ -221,6 +223,7 @@ const getActions = createSelector(
       'onDelete',
       'onUnblock',
       'peekGroupCallForTheFirstTime',
+      'peekGroupCallIfItHasMembers',
       'removeMember',
       'selectMessage',
       'clearSelectedMessage',
@@ -281,6 +284,7 @@ export class Timeline extends React.Component<
 
   private hasRecentlyScrolledTimeout?: NodeJS.Timeout;
   private delayedPeekTimeout?: NodeJS.Timeout;
+  private peekInterval?: NodeJS.Timeout;
 
   override state: StateType = {
     hasRecentlyScrolled: true,
@@ -562,18 +566,27 @@ export class Timeline extends React.Component<
 
     this.delayedPeekTimeout = setTimeout(() => {
       const { id, peekGroupCallForTheFirstTime } = this.props;
+      this.delayedPeekTimeout = undefined;
       peekGroupCallForTheFirstTime(id);
     }, 500);
+
+    this.peekInterval = setInterval(() => {
+      const { id, peekGroupCallIfItHasMembers } = this.props;
+      peekGroupCallIfItHasMembers(id);
+    }, MINUTE);
   }
 
   public override componentWillUnmount(): void {
-    const { delayedPeekTimeout } = this;
+    const { delayedPeekTimeout, peekInterval } = this;
 
     window.unregisterForActive(this.markNewestBottomVisibleMessageRead);
 
     this.intersectionObserver?.disconnect();
 
     clearTimeoutIfNecessary(delayedPeekTimeout);
+    if (peekInterval) {
+      clearInterval(peekInterval);
+    }
   }
 
   public override getSnapshotBeforeUpdate(

diff --git a/ts/services/audioRecorder.ts b/ts/services/audioRecorder.ts
@@ -102,7 +102,6 @@ export class RecorderClass {
 
   async stop(): Promise<Blob | undefined> {
     if (!this.recorder) {
-      log.warn('Recorder/stop: Called with no recorder');
       return;
     }
 

diff --git a/ts/state/ducks/calling.ts b/ts/state/ducks/calling.ts
@@ -372,6 +372,10 @@ const doGroupCallPeek = (
       return;
     }
 
+    log.info(
+      `doGroupCallPeek/groupv2(${conversation.groupId}): Found ${peekInfo.deviceCount} devices`
+    );
+
     await calling.updateCallHistoryForGroupCall(conversationId, peekInfo);
 
     const formattedPeekInfo = calling.formatGroupCallPeekInfoForRedux(peekInfo);
@@ -988,6 +992,23 @@ function peekGroupCallForTheFirstTime(
   };
 }
 
+function peekGroupCallIfItHasMembers(
+  conversationId: string
+): ThunkAction<void, RootStateType, unknown, PeekGroupCallFulfilledActionType> {
+  return (dispatch, getState) => {
+    const call = getOwn(getState().calling.callsByConversation, conversationId);
+    const shouldPeek =
+      call &&
+      call.callMode === CallMode.Group &&
+      call.joinState === GroupCallJoinState.NotJoined &&
+      call.peekInfo &&
+      call.peekInfo.deviceCount > 0;
+    if (shouldPeek) {
+      doGroupCallPeek(conversationId, dispatch, getState);
+    }
+  };
+}
+
 function peekNotConnectedGroupCall(
   payload: PeekNotConnectedGroupCallType
 ): ThunkAction<void, RootStateType, unknown, PeekGroupCallFulfilledActionType> {
@@ -1310,6 +1331,7 @@ export const actions = {
   openSystemPreferencesAction,
   outgoingCall,
   peekGroupCallForTheFirstTime,
+  peekGroupCallIfItHasMembers,
   peekNotConnectedGroupCall,
   receiveIncomingDirectCall,
   receiveIncomingGroupCall,