Skip to content

Commit

Permalink
Ensure that we show error'd recipients in message details screen
Browse files Browse the repository at this point in the history
  • Loading branch information
scottnonnenberg-signal committed Feb 21, 2019
1 parent ad53423 commit 41ea9ee
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion js/models/messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -629,11 +629,15 @@
return accumulator;
}, Object.create(null));

// We include numbers we didn't successfully send to so we can display errors.
// Older messages don't have the recipients included on the message, so we fall
// back to the conversation's current recipients
const phoneNumbers = this.isIncoming()
? [this.get('source')]
: this.get('sent_to') || this.getConversation().getRecipients();
: _.union(
this.get('sent_to') || [],
this.get('recipients') || this.getConversation().getRecipients()
);

// This will make the error message for outgoing key errors a bit nicer
const allErrors = (this.get('errors') || []).map(error => {
Expand Down

0 comments on commit 41ea9ee

Please sign in to comment.