Lightbox: Ensure that click of video pauses it

signalapp · Sep 24, 2019 · 43ac8ce · 43ac8ce
1 parent 23b720a
commit 43ac8ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/ts/components/Lightbox.tsx b/ts/components/Lightbox.tsx
@@ -71,6 +71,7 @@ const styles = {
     maxWidth: '100%',
     maxHeight: '100%',
     objectFit: 'contain',
+    outline: 'none',
   } as React.CSSProperties,
   caption: {
     position: 'absolute',
@@ -171,13 +172,10 @@ const Icon = ({
 export class Lightbox extends React.Component<Props> {
   private readonly containerRef: React.RefObject<HTMLDivElement>;
   private readonly videoRef: React.RefObject<HTMLVideoElement>;
-  private readonly playVideoBound: () => void;
 
   constructor(props: Props) {
     super(props);
 
-    this.playVideoBound = this.playVideo.bind(this);
-
     this.videoRef = React.createRef();
     this.containerRef = React.createRef();
   }
@@ -292,7 +290,6 @@ export class Lightbox extends React.Component<Props> {
         <video
           role="button"
           ref={this.videoRef}
-          onClick={this.playVideoBound}
           controls={true}
           style={styles.object}
           key={objectURL}

diff --git a/ts/util/lint/exceptions.json b/ts/util/lint/exceptions.json
@@ -7493,7 +7493,7 @@
     "rule": "React-createRef",
     "path": "ts/components/Lightbox.tsx",
     "line": "    this.videoRef = React.createRef();",
-    "lineNumber": 181,
+    "lineNumber": 179,
     "reasonCategory": "usageTrusted",
     "updated": "2019-03-09T00:08:44.242Z",
     "reasonDetail": "Used to auto-start playback on videos"