Download your own story attachments. Hydrate story replies on receive

signalapp · Aug 10, 2022 · 5b6874b · 5b6874b
1 parent 269d170
commit 5b6874b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/ts/models/messages.ts b/ts/models/messages.ts
@@ -81,6 +81,7 @@ import { handleMessageSend } from '../util/handleMessageSend';
 import { getSendOptions } from '../util/getSendOptions';
 import { findAndFormatContact } from '../util/findAndFormatContact';
 import {
+  getAttachmentsForMessage,
   getMessagePropStatus,
   getPropsForCallHistory,
   getPropsForMessage,
@@ -357,7 +358,7 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
       return;
     }
 
-    const attachments = message.get('attachments');
+    const attachments = getAttachmentsForMessage({ ...message.attributes });
 
     this.set({
       storyReplyContext: {
@@ -2444,6 +2445,10 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
           storyId: dataMessage.storyId,
         });
 
+        if (storyQuote) {
+          await this.hydrateStoryContext(storyQuote);
+        }
+
         const isSupported = !isUnsupportedMessage(message.attributes);
         if (!isSupported) {
           await message.eraseContents();

diff --git a/ts/util/shouldDownloadStory.ts b/ts/util/shouldDownloadStory.ts
@@ -4,12 +4,18 @@
 import type { ConversationAttributesType } from '../model-types.d';
 
 import dataInterface from '../sql/Client';
+import { isMe } from './whatTypeOfConversation';
 
 const MAX_NUM_STORIES_TO_PREFETCH = 5;
 
 export async function shouldDownloadStory(
   conversation: ConversationAttributesType
 ): Promise<boolean> {
+  if (isMe(conversation)) {
+    return true;
+  }
+
+  // We download the first time the user has posted a story
   if (!conversation.hasPostedStory) {
     return true;
   }